Raise error on unpermitted params.

Fail loudly if we forget to whitelist a param instead of silently
ignoring it.

misc models: convert to strong params.

artist commentaries: convert to strong params.

* Disallow changing or setting post_id to a nonexistent post.

artists: convert to strong params.

* Disallow setting `is_banned` in create/update actions. Changing it
  this way instead of with the ban/unban actions would leave the artist in
  a partially banned state.

bans: convert to strong params.

* Disallow changing the user_id after the ban has been created.

comments: convert to strong params.

favorite groups: convert to strong params.

news updates: convert to strong params.

post appeals: convert to strong params.

post flags: convert to strong params.

* Disallow users from setting the `is_deleted` / `is_resolved` flags.

ip bans: convert to strong params.

user feedbacks: convert to strong params.

* Disallow users from setting `disable_dmail_notification` when creating feedbacks.
* Disallow changing the user_id after the feedback has been created.

notes: convert to strong params.

wiki pages: convert to strong params.

* Also fix non-Builders being able to delete wiki pages.

saved searches: convert to strong params.

pools: convert to strong params.

* Disallow setting `post_count` or `is_deleted` in create/update actions.

janitor trials: convert to strong params.

post disapprovals: convert to strong params.

* Factor out quick-mod bar to shared partial.
* Fix quick-mod bar to use `Post#is_approvable?` to determine visibility
  of Approve button.

dmail filters: convert to strong params.

password resets: convert to strong params.

user name change requests: convert to strong params.

posts: convert to strong params.

users: convert to strong params.

* Disallow setting password_hash, last_logged_in_at, last_forum_read_at,
  has_mail, and dmail_filter_attributes[user_id].

* Remove initialize_default_image_size (dead code).

uploads: convert to strong params.

* Remove `initialize_status` because status already defaults to pending
  in the database.

tag aliases/implications: convert to strong params.

tags: convert to strong params.

forum posts: convert to strong params.

* Disallow changing the topic_id after creating the post.
* Disallow setting is_deleted (destroy/undelete actions should be used instead).
* Remove is_sticky / is_locked (nonexistent attributes).

forum topics: convert to strong params.

* merges https://github.com/evazion/danbooru/tree/wip-rails-5.1
* lock pg gem to 0.21 (1.0.0 is incompatible with rails 5.1.4)
* switch to factorybot and change all references

Co-authored-by: r888888888 <r888888888@gmail.com>
Co-authored-by: evazion <noizave@gmail.com>

add diffs

test/unit/favorite_test.rb

@@ -2,7 +2,7 @@ require 'test_helper'
 
 class FavoriteTest < ActiveSupport::TestCase
   setup do
-    user = FactoryGirl.create(:user)
+    user = FactoryBot.create(:user)
     CurrentUser.user = user
     CurrentUser.ip_addr = "127.0.0.1"
     Favorite # need to force loading the favorite model
@@ -15,21 +15,21 @@ class FavoriteTest < ActiveSupport::TestCase
 
   context "A favorite" do
     should "delete from all tables" do
-      user1 = FactoryGirl.create(:user)
-      p1 = FactoryGirl.create(:post)
+      user1 = FactoryBot.create(:user)
+      p1 = FactoryBot.create(:post)
 
       user1.add_favorite!(p1)
       assert_equal(1, Favorite.count)
 
-      Favorite.destroy_all(:user_id => user1.id, :post_id => p1.id)
+      Favorite.where(:user_id => user1.id, :post_id => p1.id).delete_all
       assert_equal(0, Favorite.count)
     end
 
     should "know which table it belongs to" do
-      user1 = FactoryGirl.create(:user)
-      user2 = FactoryGirl.create(:user)
-      p1 = FactoryGirl.create(:post)
-      p2 = FactoryGirl.create(:post)
+      user1 = FactoryBot.create(:user)
+      user2 = FactoryBot.create(:user)
+      p1 = FactoryBot.create(:post)
+      p2 = FactoryBot.create(:post)
 
       user1.add_favorite!(p1)
       user1.add_favorite!(p2)
@@ -46,9 +46,9 @@ class FavoriteTest < ActiveSupport::TestCase
     end
 
     should "not allow duplicates" do
-      user1 = FactoryGirl.create(:user)
-      p1 = FactoryGirl.create(:post)
-      p2 = FactoryGirl.create(:post)
+      user1 = FactoryBot.create(:user)
+      p1 = FactoryBot.create(:post)
+      p2 = FactoryBot.create(:post)
       user1.add_favorite!(p1)
       user1.add_favorite!(p1)