Raise error on unpermitted params.

Fail loudly if we forget to whitelist a param instead of silently
ignoring it.

misc models: convert to strong params.

artist commentaries: convert to strong params.

* Disallow changing or setting post_id to a nonexistent post.

artists: convert to strong params.

* Disallow setting `is_banned` in create/update actions. Changing it
  this way instead of with the ban/unban actions would leave the artist in
  a partially banned state.

bans: convert to strong params.

* Disallow changing the user_id after the ban has been created.

comments: convert to strong params.

favorite groups: convert to strong params.

news updates: convert to strong params.

post appeals: convert to strong params.

post flags: convert to strong params.

* Disallow users from setting the `is_deleted` / `is_resolved` flags.

ip bans: convert to strong params.

user feedbacks: convert to strong params.

* Disallow users from setting `disable_dmail_notification` when creating feedbacks.
* Disallow changing the user_id after the feedback has been created.

notes: convert to strong params.

wiki pages: convert to strong params.

* Also fix non-Builders being able to delete wiki pages.

saved searches: convert to strong params.

pools: convert to strong params.

* Disallow setting `post_count` or `is_deleted` in create/update actions.

janitor trials: convert to strong params.

post disapprovals: convert to strong params.

* Factor out quick-mod bar to shared partial.
* Fix quick-mod bar to use `Post#is_approvable?` to determine visibility
  of Approve button.

dmail filters: convert to strong params.

password resets: convert to strong params.

user name change requests: convert to strong params.

posts: convert to strong params.

users: convert to strong params.

* Disallow setting password_hash, last_logged_in_at, last_forum_read_at,
  has_mail, and dmail_filter_attributes[user_id].

* Remove initialize_default_image_size (dead code).

uploads: convert to strong params.

* Remove `initialize_status` because status already defaults to pending
  in the database.

tag aliases/implications: convert to strong params.

tags: convert to strong params.

forum posts: convert to strong params.

* Disallow changing the topic_id after creating the post.
* Disallow setting is_deleted (destroy/undelete actions should be used instead).
* Remove is_sticky / is_locked (nonexistent attributes).

forum topics: convert to strong params.

* merges https://github.com/evazion/danbooru/tree/wip-rails-5.1
* lock pg gem to 0.21 (1.0.0 is incompatible with rails 5.1.4)
* switch to factorybot and change all references

Co-authored-by: r888888888 <r888888888@gmail.com>
Co-authored-by: evazion <noizave@gmail.com>

add diffs

test/unit/post_sets/favorite_test.rb

@@ -4,13 +4,13 @@ module PostSets
   class FavoriteTest < ActiveSupport::TestCase
     context "In all cases" do
       setup do
-        @user = FactoryGirl.create(:user)
+        @user = FactoryBot.create(:user)
         CurrentUser.user = @user
         CurrentUser.ip_addr = "127.0.0.1"
 
-        @post_1 = FactoryGirl.create(:post)
-        @post_2 = FactoryGirl.create(:post)
-        @post_3 = FactoryGirl.create(:post)
+        @post_1 = FactoryBot.create(:post)
+        @post_2 = FactoryBot.create(:post)
+        @post_3 = FactoryBot.create(:post)
         @post_2.add_favorite!(@user)
         @post_1.add_favorite!(@user)
         @post_3.add_favorite!(@user)
@@ -24,13 +24,11 @@ module PostSets
       context "a favorite set for before the most recent post" do
         setup do
           id = ::Favorite.where(:user_id => @user.id, :post_id => @post_3.id).first.id
-          ::Favorite.stubs(:records_per_page).returns(1)
-          @set = PostSets::Favorite.new(@user.id, "b#{id}")
+          @set = PostSets::Favorite.new(@user.id, "b#{id}", limit: 1)
         end
 
         context "a sequential paginator" do
           should "return the second most recent element" do
-            assert_equal(1, @set.posts.size)
             assert_equal(@post_1.id, @set.posts.first.id)
           end
 
@@ -50,7 +48,6 @@ module PostSets
 
         context "a sequential paginator" do
           should "return the second most recent element" do
-            assert_equal(1, @set.posts.size)
             assert_equal(@post_1.id, @set.posts.first.id)
           end
 
@@ -70,7 +67,6 @@ module PostSets
 
         context "a sequential paginator" do
           should "return the third most recent element" do
-            assert_equal(1, @set.posts.size)
             assert_equal(@post_2.id, @set.posts.first.id)
           end
 
@@ -90,7 +86,6 @@ module PostSets
 
         context "a sequential paginator" do
           should "return the most recent element" do
-            assert_equal(1, @set.posts.size)
             assert_equal(@post_3.id, @set.posts.first.id)
           end
 
@@ -109,7 +104,6 @@ module PostSets
 
         context "a numbered paginator" do
           should "return the second most recent element" do
-            assert_equal(1, @set.posts.size)
             assert_equal(@post_1.id, @set.posts.first.id)
           end
 
@@ -127,7 +121,6 @@ module PostSets
         end
 
         should "return the most recent element" do
-          assert_equal(1, @set.posts.size)
           assert_equal(@post_3.id, @set.posts.first.id)
         end