posts/index: fix rating:s being included in page title in safe mode.

Fixes bug described in d3e4ac7c17 (commitcomment-39049351)

When dealing with searches, there are several variables we have to keep
in mind:

* Whether tag aliases should be applied.
* Whether search terms should be sorted.
* Whether the rating:s and -status:deleted metatags should be added by
  safe mode and the hide deleted posts setting.

Which of these things we need to do depends on the context:

* We want to apply aliases when actually doing the search, calculating
  the count, looking up the wiki excerpt, recording missed/popular
  searches in Reportbooru, and calculating related tags for the sidebar,
  but not when displaying the raw search as typed by the user (for
  example, in the page title or in the tag search box).
* We want to sort the search when calculating cache keys for fast_count
  or related tags, and when recording missed/popular searches, but not
  in the page title or when displaying the raw search.
* We want to add rating:s and -status:deleted when performing the
  search, calculating the count, or recording missed/popular searches,
  but not when calculating related tags for the sidebar, or when
  displaying the page title or raw search.

Here we introduce normalized_query and try to use it in contexts where
query normalization is necessary. When to use the normalized query
versus the raw unnormalized query is still subtle and prone to error.

app/logical/post_query_builder.rb

@@ -53,22 +53,15 @@ class PostQueryBuilder
     COUNT_METATAG_SYNONYMS.flat_map { |str| [str, "#{str}_asc"] } +
     CATEGORY_COUNT_METATAGS.flat_map { |str| [str, "#{str}_asc"] }
 
-  attr_reader :query_string, :terms, :current_user, :safe_mode, :hide_deleted_posts
+  attr_reader :query_string, :current_user, :safe_mode, :hide_deleted_posts
   alias_method :safe_mode?, :safe_mode
   alias_method :hide_deleted_posts?, :hide_deleted_posts
 
-  def initialize(query_string, current_user = User.anonymous, normalize_aliases: true, normalize_order: true, safe_mode: false, hide_deleted_posts: false)
+  def initialize(query_string, current_user = User.anonymous, safe_mode: false, hide_deleted_posts: false)
     @query_string = query_string
     @current_user = current_user
     @safe_mode = safe_mode
     @hide_deleted_posts = hide_deleted_posts
-
-    @terms = scan_query
-    @terms << OpenStruct.new(type: :metatag, name: "rating", value: "s") if safe_mode?
-    @terms << OpenStruct.new(type: :metatag, name: "status", value: "deleted", negated: true) if hide_deleted?
-
-    normalize_aliases! if normalize_aliases
-    normalize_order! if normalize_order
   end
 
   def tags_match(tags, relation)
@@ -457,11 +450,6 @@ class PostQueryBuilder
     relation
   end
 
-  def hide_deleted?
-    has_status_metatag = select_metatags(:status).any? { |metatag| metatag.value.downcase.in?(%w[deleted active any all]) }
-    hide_deleted_posts? && !has_status_metatag
-  end
-
   def build
     tag_count = terms.count { |term| !Danbooru.config.is_unlimited_tag?(term) }
     if tag_count > Danbooru.config.tag_query_limit
@@ -695,20 +683,6 @@ class PostQueryBuilder
       end
     end
 
-    def normalize_aliases!
-      tag_names = tags.map(&:name)
-      tag_aliases = tag_names.zip(TagAlias.to_aliased(tag_names)).to_h
-
-      terms.map! do |term|
-        term.name = tag_aliases[term.name] if term.type == :tag
-        term
-      end
-    end
-
-    def normalize_order!
-      terms.sort_by!(&:to_s).uniq!
-    end
-
     def parse_tag_edit
       split_query
     end
@@ -884,11 +858,51 @@ class PostQueryBuilder
     end
   end
 
+  concerning :NormalizationMethods do
+    def normalized_query(implicit: true, sort: true)
+      post_query = dup
+      post_query.terms.concat(implicit_metatags) if implicit
+      post_query.normalize_aliases!
+      post_query.normalize_order! if sort
+      post_query
+    end
+
+    def normalize_aliases!
+      tag_names = tags.map(&:name)
+      tag_aliases = tag_names.zip(TagAlias.to_aliased(tag_names)).to_h
+
+      terms.map! do |term|
+        term.name = tag_aliases[term.name] if term.type == :tag
+        term
+      end
+    end
+
+    def normalize_order!
+      terms.sort_by!(&:to_s).uniq!
+    end
+
+    def implicit_metatags
+      metatags = []
+      metatags << OpenStruct.new(type: :metatag, name: "rating", value: "s") if safe_mode?
+      metatags << OpenStruct.new(type: :metatag, name: "status", value: "deleted", negated: true) if hide_deleted?
+      metatags
+    end
+
+    def hide_deleted?
+      has_status_metatag = select_metatags(:status).any? { |metatag| metatag.value.downcase.in?(%w[deleted active any all]) }
+      hide_deleted_posts? && !has_status_metatag
+    end
+  end
+
   concerning :UtilityMethods do
     def to_s
       split_query.join(" ")
     end
 
+    def terms
+      @terms ||= scan_query
+    end
+
     def tags
       terms.select { |term| term.type == :tag }
     end
@@ -943,5 +957,5 @@ class PostQueryBuilder
     end
   end
 
-  memoize :split_query
+  memoize :split_query, :normalized_query
 end