jaculabilis/danbooru
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

tags: ensure aliased tag categories stay in sync.

Browse Source 
* When a tag's category is changed, also change the category of any aliases pointing to it. For
  example, if "ff7" is aliased to "final_fantasy_vii", and "final_fantasy_vii" is changed to a
  copyright tag, then change the empty "ff7" tag to be a copyright tag too.

* Don't allow changing the category of an aliased tag. For example, if "ff7" is aliased to
  "final_fantasy_vii", then don't allow changing the "ff7" tag to be a non-copyright tag.

This ensures that the categories of aliased tags stay in sync with that of their parent tags. This
way aliased tags are colored correctly in wikis and other places.
This commit is contained in:
evazion
2022-11-22 21:54:22 -06:00
parent 1a9718250f
commit b234727832
4 changed files with 54 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
test/unit/post_test.rb
View File

@@ -587,13 +587,13 @@ class PostTest < ActiveSupport::TestCase
assert_equal(Tag.categories.character, tag.last_version.category)
end
should "change the category for an aliased tag" do
should "not change the category for an aliased tag" do
create(:tag_alias, antecedent_name: "hoge", consequent_name: "moge")
post = create(:post, tag_string: "char:hoge")
assert_equal(["moge"], post.tag_array)
assert_equal(Tag.categories.general, Tag.find_by_name("moge").category)
assert_equal(Tag.categories.character, Tag.find_by_name("hoge").category)
assert_equal(Tag.categories.general, Tag.find_by_name("hoge").category)
end
should "not raise an exception for an invalid tag name" do

20
test/unit/tag_test.rb
View File

@@ -175,6 +175,17 @@ class TagTest < ActiveSupport::TestCase
assert_equal(0, tag.reload.category)
end
should "not change category if the tag is aliased" do
t1 = create(:tag, name: "ff7", category: Tag.categories.copyright)
t2 = create(:tag, name: "final_fantasy_vii", category: Tag.categories.copyright)
ta = create(:tag_alias, antecedent_name: "ff7", consequent_name: "final_fantasy_vii")
t1.reload.category = Tag.categories.character
assert_equal(false, t1.valid?)
assert_equal(["Can't change the category of an aliased tag"], t1.errors[:base])
end
should "update post tag counts when the category is changed" do
post = FactoryBot.create(:post, tag_string: "test")
assert_equal(1, post.tag_count_general)
@@ -186,6 +197,15 @@ class TagTest < ActiveSupport::TestCase
assert_equal(1, post.tag_count_character)
end
should "update aliased tags when the tag's category is changed" do
t1 = create(:tag, name: "ff7", category: Tag.categories.general)
t2 = create(:tag, name: "final_fantasy_vii", category: Tag.categories.general)
ta = create(:tag_alias, antecedent_name: "ff7", consequent_name: "final_fantasy_vii")
t2.update!(category: Tag.categories.copyright, updater: User.system)
assert_equal("Copyright", t1.reload.category_name)
end
should "be created when one doesn't exist" do
assert_difference("Tag.count", 1) do
tag = Tag.find_or_create_by_name("hoge")