From b24ccb0595e82e3d6e3f22b3227d9b68611de470 Mon Sep 17 00:00:00 2001 From: evazion Date: Tue, 18 Dec 2018 19:10:23 -0600 Subject: [PATCH] tag edit dialog: fix clicking button before handler is bound. https://danbooru.donmai.us/forum_topics/9127?page=265#forum_post_153180: > I'm not sure how to reproduce this, but sometimes on the upload page > when I click the button to pop out the tag box, the screen scrolls up to > the picture but the box doesn't pop out, and I have to scroll back down > and click it again https://danbooru.donmai.us/forum_topics/9127?page=266#forum_post_153183: > Yes, this was brought up by Unbreakable on Discord a while back. It's > due to the fact that the event handler that pops out the dialog box has > not yet been bound by the time you click it. Since that clickable > control has an empty anchor link of "#" which goes nowhere, it therefore > redirects the user to the top of the page. --- app/views/posts/partials/show/_edit.html.erb | 2 +- app/views/uploads/new.html.erb | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/app/views/posts/partials/show/_edit.html.erb b/app/views/posts/partials/show/_edit.html.erb index be5b76e3d..662b011bc 100644 --- a/app/views/posts/partials/show/_edit.html.erb +++ b/app/views/posts/partials/show/_edit.html.erb @@ -84,7 +84,7 @@ - + diff --git a/app/views/uploads/new.html.erb b/app/views/uploads/new.html.erb index 80ff66e13..10c475388 100644 --- a/app/views/uploads/new.html.erb +++ b/app/views/uploads/new.html.erb @@ -97,7 +97,7 @@ - +