models: remove belongs_to_creator macro.

The belongs_to_creator macro was used to initialize the creator_id field
to the CurrentUser. This made tests complicated because it meant you had
to create and set the current user every time you wanted to create an
object, when lead to the current user being set over and over again. It
also meant you had to constantly be aware of what the CurrentUser was in
many different contexts, which was often confusing. Setting creators
explicitly simplifies everything greatly.

test/factories/artist.rb

@@ -1,7 +1,7 @@
 FactoryBot.define do
   factory(:artist) do
+    creator
     name { rand(1_000_000).to_s }
     is_active { true }
-    association :creator, factory: :user
   end
 end

test/factories/bulk_update_request.rb

@@ -1,5 +1,6 @@
 FactoryBot.define do
   factory(:bulk_update_request) do |f|
+    user
     title {"xxx"}
     script {"create alias aaa -> bbb"}
     skip_secondary_validations {true}

test/factories/comment.rb

@@ -1,6 +1,8 @@
 FactoryBot.define do
   factory(:comment) do |f|
+    creator
     post
+    creator_ip_addr { FFaker::Internet.ip_v4_address }
     body {FFaker::Lorem.sentences.join(" ")}
   end
 end

test/factories/favorite_group.rb

@@ -1,5 +1,6 @@
 FactoryBot.define do
   factory :favorite_group do
+    creator
     name { FFaker::Lorem.word }
   end
 end

test/factories/forum_post.rb

@@ -1,5 +1,6 @@
 FactoryBot.define do
   factory(:forum_post) do
+    creator
     body {FFaker::Lorem.sentences.join(" ")}
   end
 end

test/factories/forum_topic.rb

@@ -1,5 +1,6 @@
 FactoryBot.define do
   factory(:forum_topic) do
+    creator
     title {FFaker::Lorem.words.join(" ")}
     is_sticky {false}
     is_locked {false}

test/factories/news_update.rb

@@ -1,5 +1,6 @@
 FactoryBot.define do
   factory(:news_update) do
+    creator
     message {"xxx"}
   end
 end

test/factories/note.rb

@@ -1,5 +1,6 @@
 FactoryBot.define do
   factory(:note) do
+    creator
     post
     x { 1 }
     y { 1 }

test/factories/pool.rb

@@ -1,7 +1,7 @@
 FactoryBot.define do
   factory(:pool) do
+    creator
     name {"pool_" + rand(100..1000099).to_s}
-    association :creator, :factory => :user
     description {FFaker::Lorem.sentences.join(" ")}
   end
 end

test/factories/post_appeal.rb

@@ -1,5 +1,7 @@
 FactoryBot.define do
   factory(:post_appeal) do
+    creator
+    post
     reason {"xxx"}
   end
 end

test/factories/post_flag.rb

@@ -1,5 +1,7 @@
 FactoryBot.define do
   factory(:post_flag) do
+    creator
+    post
     reason {"xxx"}
     is_resolved {false}
   end

test/factories/tag_alias.rb

@@ -1,5 +1,6 @@
 FactoryBot.define do
   factory :tag_alias do
+    creator
     antecedent_name {"aaa"}
     consequent_name {"bbb"}
     status {"active"}

test/factories/tag_implication.rb

@@ -1,5 +1,6 @@
 FactoryBot.define do
   factory :tag_implication do
+    creator
     antecedent_name {"aaa"}
     consequent_name {"bbb"}
     status {"active"}

test/factories/user.rb

@@ -11,6 +11,7 @@ FactoryBot.define do
     last_logged_in_at {Time.now}
     favorite_count {0}
     bit_prefs {0}
+    last_forum_read_at {nil}
 
     factory(:banned_user) do
       transient { ban_duration {3} }

test/factories/user_feedback.rb

@@ -1,5 +1,6 @@
 FactoryBot.define do
   factory(:user_feedback) do
+    creator factory: :builder_user
     user
     category { "positive" }
     body { FFaker::Lorem.words.join(" ") }