jaculabilis/danbooru
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

users: remove option to disable search navbar.

Browse Source 
Remove the enable_sequential_post_navigation option. This option was
used to disable the next/previous post navbar below posts.

This option was originally added in issue #674 because of people
complaining about the navbar when it was originally added. Also there
were complaints about URLs being uglier because of search params in the
URL (e.g. /posts/1234?q=touhou). There were also various minor bugs with
it at the time, such as keyboard shortcuts not working correctly, or the
page not remembering your search after a tag edit.

These complaints are irrelevant nowadays because a) people are used to
the navbar by now (and more often complain about it *not* being there
for order:score searches), b) post URLs always contain the search now,
this option hasn't disabled that for years, and c) the initial bugs with
it were fixed years ago.

Only ~1000 users disabled this option and only ~600 were seen in the last year.

Users still wishing to hide the search navbar can use custom CSS instead.
This commit is contained in:
evazion
2021-01-14 15:00:43 -06:00
parent c48ee9d390
commit b6fef7f3f3
5 changed files with 8 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
app/policies/user_policy.rb
View File

@@ -45,12 +45,11 @@ class UserPolicy < ApplicationPolicy
:blacklisted_tags, :time_zone, :per_page, :custom_style, :theme,
:receive_email_notifications, :always_resize_images,
:enable_post_navigation, :new_post_navigation_layout,
:enable_private_favorites, :enable_sequential_post_navigation,
:hide_deleted_posts, :style_usernames, :enable_auto_complete,
:show_deleted_children, :disable_categorized_saved_searches,
:disable_tagged_filenames, :disable_cropped_thumbnails,
:disable_mobile_gestures, :enable_safe_mode, :enable_desktop_mode,
:disable_post_tooltips,
:enable_private_favorites, :hide_deleted_posts, :style_usernames,
:enable_auto_complete, :show_deleted_children,
:disable_categorized_saved_searches, :disable_tagged_filenames,
:disable_cropped_thumbnails, :disable_mobile_gestures, :enable_safe_mode,
:enable_desktop_mode, :disable_post_tooltips,
].compact
end