From c5de983f611f2a711702beee9676c9ecb92ad78e Mon Sep 17 00:00:00 2001 From: evazion Date: Tue, 23 May 2017 11:47:43 -0500 Subject: [PATCH 1/3] Post#favorited_by?: fix to return a boolean. --- app/models/post.rb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/app/models/post.rb b/app/models/post.rb index aa31fd2b2..d45202759 100644 --- a/app/models/post.rb +++ b/app/models/post.rb @@ -954,7 +954,7 @@ class Post < ActiveRecord::Base end def favorited_by?(user_id) - fav_string =~ /(?:\A| )fav:#{user_id}(?:\Z| )/ + fav_string.split.include?("fav:#{user_id}") end def append_user_to_fav_string(user_id) From 4c61e547b95b4c4ec16b9ccf9a0ed2af32a3c007 Mon Sep 17 00:00:00 2001 From: evazion Date: Tue, 23 May 2017 11:48:20 -0500 Subject: [PATCH 2/3] posts: add `data-is-favorited` attribute to thumbnails. --- app/presenters/post_presenter.rb | 1 + 1 file changed, 1 insertion(+) diff --git a/app/presenters/post_presenter.rb b/app/presenters/post_presenter.rb index eaee5e70e..9e3af7ee1 100644 --- a/app/presenters/post_presenter.rb +++ b/app/presenters/post_presenter.rb @@ -90,6 +90,7 @@ class PostPresenter < Presenter data-preview-file-url="#{post.preview_file_url}" data-source="#{h(post.source)}" data-normalized-source="#{h(post.normalized_source)}" + data-is-favorited="#{post.favorited_by?(CurrentUser.user.id)}" }.html_safe end From 3aa405eac19e82960d47471b918025b4a252a660 Mon Sep 17 00:00:00 2001 From: evazion Date: Tue, 23 May 2017 13:12:10 -0500 Subject: [PATCH 3/3] Post#favorited_by?: fix to cast to a boolean. --- app/models/post.rb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/app/models/post.rb b/app/models/post.rb index d45202759..0edeb5ff5 100644 --- a/app/models/post.rb +++ b/app/models/post.rb @@ -954,7 +954,7 @@ class Post < ActiveRecord::Base end def favorited_by?(user_id) - fav_string.split.include?("fav:#{user_id}") + !!(fav_string =~ /(?:\A| )fav:#{user_id}(?:\Z| )/) end def append_user_to_fav_string(user_id)