From be4646aa6ffe0a80c499e667a7b9435009b49440 Mon Sep 17 00:00:00 2001 From: evazion Date: Thu, 11 Jun 2020 02:43:19 -0500 Subject: [PATCH] tests: fix username conflicts in parallel tests. Parallel tests sometimes failed because the username generator sometimes generated duplicate usernames. --- test/factories/post.rb | 4 +--- test/factories/user.rb | 4 +--- 2 files changed, 2 insertions(+), 6 deletions(-) diff --git a/test/factories/post.rb b/test/factories/post.rb index 96260eb40..befeb2b40 100644 --- a/test/factories/post.rb +++ b/test/factories/post.rb @@ -1,8 +1,6 @@ FactoryBot.define do factory(:post) do - sequence :md5 do |n| - n.to_s - end + md5 { SecureRandom.hex(32) } uploader uploader_ip_addr {"127.0.0.1"} tag_string {"tag1 tag2"} diff --git a/test/factories/user.rb b/test/factories/user.rb index 8dd25950b..8eff8378d 100644 --- a/test/factories/user.rb +++ b/test/factories/user.rb @@ -1,8 +1,6 @@ FactoryBot.define do factory(:user, aliases: [:creator, :updater]) do - sequence :name do |n| - "user#{n}" - end + name { FFaker::Internet.user_name + $PID.to_s } password {"password"} default_image_size {"large"} level {20}