jaculabilis/danbooru
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

wiki pages: warn when renaming wikis still linked from other wikis.

Browse Source 
* Warn when renaming a wiki that still has links from other wikis.
* When renaming a wiki that still has posts, just show a warning instead
  of returning an error and making the user confirm the rename.
This commit is contained in:
evazion
2019-12-16 18:32:48 -06:00
parent b038761fa7
commit be9bdc0ab3
4 changed files with 19 additions and 21 deletions
Download Patch File Download Diff File Expand all files Collapse all files

21
app/models/wiki_page.rb
View File

@@ -13,7 +13,6 @@ class WikiPage < ApplicationRecord
validate :validate_rename
validate :validate_not_locked
attr_accessor :skip_secondary_validations
array_attribute :other_names
has_one :tag, :foreign_key => "name", :primary_key => "title"
has_one :artist, -> {where(:is_active => true)}, :foreign_key => "name", :primary_key => "title"
@@ -62,6 +61,10 @@ class WikiPage < ApplicationRecord
where(title: Tag.search(params).select(:name).reorder(nil))
end
def linked_to(title)
where(id: DtextLink.wiki_page.wiki_link.where(link_target: title).select(:model_id))
end
def default_order
order(updated_at: :desc)
end
@@ -85,7 +88,7 @@ class WikiPage < ApplicationRecord
end
if params[:linked_to].present?
q = q.where(id: DtextLink.wiki_page.wiki_link.where(link_target: params[:linked_to]).select(:model_id))
q = q.linked_to(params[:linked_to])
end
if params[:hide_deleted].to_s.truthy?
@@ -121,11 +124,17 @@ class WikiPage < ApplicationRecord
end
def validate_rename
return if !will_save_change_to_title? || skip_secondary_validations
return unless title_changed?
tag_was = Tag.find_by_name(Tag.normalize_name(title_was))
if tag_was.present? && tag_was.post_count > 0
errors.add(:title, "cannot be changed: '#{tag_was.name}' still has #{tag_was.post_count} posts. Move the posts and update any wikis linking to this page first.")
warnings[:base] << %Q!Warning: {{#{title_was}}} still has #{tag_was.post_count} #{"post".pluralize(tag_was.post_count)}. Be sure to move the posts!
end
broken_wikis = WikiPage.linked_to(title_was)
if broken_wikis.count > 0
broken_wiki_search = Rails.application.routes.url_helpers.wiki_pages_path(search: { linked_to: title_was })
warnings[:base] << %Q!Warning: [[#{title_was}]] is still linked from "#{broken_wikis.count} #{"other wiki page".pluralize(broken_wikis.count)}":[#{broken_wiki_search}]. Update #{broken_wikis.count > 1 ? "these wikis" : "this wiki"} to link to [[#{title}]] instead!
end
end
@@ -161,10 +170,6 @@ class WikiPage < ApplicationRecord
name.unicode_normalize(:nfkc).gsub(/[[:space:]]+/, " ").strip.tr(" ", "_")
end
def skip_secondary_validations=(value)
@skip_secondary_validations = value.to_s.truthy?
end
def category_name
Tag.category_for(title)
end