jaculabilis/danbooru
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

String: add truthy? & falsy? core extensions.

Browse Source 
* Add `truthy?` and `falsy?` core extensions to String.

* Use `truthy?` and `falsy?` to replace ad-hoc parsing of boolean
  parameters in various places.
This commit is contained in:
evazion
2018-05-03 18:53:35 -05:00
parent 96669ca4b5
commit c7492343ce
15 changed files with 62 additions and 102 deletions
Download Patch File Download Diff File Expand all files Collapse all files

26
app/models/post.rb
View File

@@ -1820,28 +1820,20 @@ class Post < ApplicationRecord
end
def mark_as_translated(params)
tags = self.tag_array.dup
add_tag("check_translation") if params["check_translation"].to_s.truthy?
remove_tag("check_translation") if params["check_translation"].to_s.falsy?
if params["check_translation"] == "1"
tags << "check_translation"
elsif params["check_translation"] == "0"
tags -= ["check_translation"]
end
if params["partially_translated"] == "1"
tags << "partially_translated"
elsif params["partially_translated"] == "0"
tags -= ["partially_translated"]
end
add_tag("partially_translated") if params["partially_translated"].to_s.truthy?
remove_tag("partially_translated") if params["partially_translated"].to_s.falsy?
if params["check_translation"] == "1" || params["partially_translated"] == "1"
tags << "translation_request"
tags -= ["translated"]
if has_tag?("check_translation") || has_tag?("partially_translated")
add_tag("translation_request")
remove_tag("translated")
else
tags << "translated"
tags -= ["translation_request"]
add_tag("translated")
remove_tag("translation_request")
end
self.tag_string = tags.join(" ")
save
end