jaculabilis/danbooru
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

String: add truthy? & falsy? core extensions.

Browse Source 
* Add `truthy?` and `falsy?` core extensions to String.

* Use `truthy?` and `falsy?` to replace ad-hoc parsing of boolean
  parameters in various places.
This commit is contained in:
evazion
2018-05-03 18:53:35 -05:00
parent 96669ca4b5
commit c7492343ce
15 changed files with 62 additions and 102 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
app/models/wiki_page.rb
View File

@@ -82,13 +82,13 @@ class WikiPage < ApplicationRecord
q = q.where("creator_id = (select _.id from users _ where lower(_.name) = ?)", params[:creator_name].tr(" ", "_").mb_chars.downcase)
end
if params[:hide_deleted] =~ /y/i
if params[:hide_deleted].to_s.truthy?
q = q.where("is_deleted = false")
end
if params[:other_names_present] == "yes"
if params[:other_names_present].to_s.truthy?
q = q.where("other_names is not null and other_names != ''")
elsif params[:other_names_present] == "no"
elsif params[:other_names_present].to_s.falsy?
q = q.where("other_names is null or other_names = ''")
end
@@ -165,7 +165,7 @@ class WikiPage < ApplicationRecord
end
def skip_secondary_validations=(value)
@skip_secondary_validations = (value == true || value == "1")
@skip_secondary_validations = value.to_s.truthy?
end
def category_name