From c8e3f957da58ff4f5bc2ccedec7ba65cbd3a00bb Mon Sep 17 00:00:00 2001 From: evazion Date: Tue, 22 Nov 2022 22:10:52 -0600 Subject: [PATCH] tests: fix broken tests. --- test/functional/users_controller_test.rb | 1 - test/unit/post_test.rb | 11 +++++------ 2 files changed, 5 insertions(+), 7 deletions(-) diff --git a/test/functional/users_controller_test.rb b/test/functional/users_controller_test.rb index df3a3df97..035835f2e 100644 --- a/test/functional/users_controller_test.rb +++ b/test/functional/users_controller_test.rb @@ -161,7 +161,6 @@ class UsersControllerTest < ActionDispatch::IntegrationTest assert_redirected_to posts_path assert_equal(true, @user.reload.is_deleted?) assert_equal("Your account has been deactivated", flash[:notice]) - assert_nil(session[:user_id]) assert_equal(true, @user.user_events.user_deletion.exists?) end diff --git a/test/unit/post_test.rb b/test/unit/post_test.rb index cb681a514..a51c83066 100644 --- a/test/unit/post_test.rb +++ b/test/unit/post_test.rb @@ -383,13 +383,12 @@ class PostTest < ActiveSupport::TestCase end context "with a banned artist" do - setup do - @artist = create(:artist, is_banned: true) - @post = FactoryBot.create(:post, :tag_string => @artist.name) - end - should "ban the post" do - assert_equal(true, @post.is_banned?) + artist = create(:artist) + implication = create(:tag_implication, antecedent_name: artist.name, consequent_name: "banned_artist") + post = create(:post, tag_string: artist.name) + + assert_equal(true, post.is_banned?) end end