From c9e3c293a998ce41fc6873952df89075d5872829 Mon Sep 17 00:00:00 2001
From: NamelessContributor <NamelessContributor@users.noreply.github.com>
Date: Tue, 8 Mar 2022 08:54:45 +0100
Subject: [PATCH] Always add animate-spin class to spinner_icon

This also fixes the source data and fav button spinners not spinning
after commit 77515915a47b446a68d42200e84c45374102abbe
---
 .../file_upload_component/file_upload_component.html.erb        | 2 +-
 .../media_asset_preview_component.html.erb                      | 2 +-
 app/helpers/icon_helper.rb                                      | 2 +-
 app/views/upload_media_assets/_preview.html.erb                 | 2 +-
 4 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/app/components/file_upload_component/file_upload_component.html.erb b/app/components/file_upload_component/file_upload_component.html.erb
index 98f024ae2..1adb246bd 100644
--- a/app/components/file_upload_component/file_upload_component.html.erb
+++ b/app/components/file_upload_component/file_upload_component.html.erb
@@ -16,7 +16,7 @@
     <%= f.submit "Upload", class: "button-primary text-center mx-auto hidden", "data-disable-with": false %>
   <% end %>
 
-  <%= spinner_icon(class: "hidden animate-spin absolute inset-0 m-auto h-12 link-color") %>
+  <%= spinner_icon(class: "hidden absolute inset-0 m-auto h-12 link-color") %>
 
   <template class="dropzone-preview-template">
     <div class="dz-preview dz-file-preview flex flex-col text-center">
diff --git a/app/components/media_asset_preview_component/media_asset_preview_component.html.erb b/app/components/media_asset_preview_component/media_asset_preview_component.html.erb
index 14d899a17..c657d26d9 100644
--- a/app/components/media_asset_preview_component/media_asset_preview_component.html.erb
+++ b/app/components/media_asset_preview_component/media_asset_preview_component.html.erb
@@ -30,7 +30,7 @@
     <% else %>
       <div class="media-asset-placeholder rounded border border-solid flex items-center justify-center w-<%= size %>px h-<%= size %>px">
         <% if media_asset.processing? %>
-          <%= spinner_icon(class: "animate-spin h-8") %>
+          <%= spinner_icon(class: "h-8") %>
         <% elsif media_asset.failed? %>
           Failed
         <% else %>
diff --git a/app/helpers/icon_helper.rb b/app/helpers/icon_helper.rb
index 2e53b6961..3b1e8b1e0 100644
--- a/app/helpers/icon_helper.rb
+++ b/app/helpers/icon_helper.rb
@@ -81,7 +81,7 @@ module IconHelper
   end
 
   def spinner_icon(**options)
-    svg_icon_tag("spinner-icon", "M304 48C304 74.51 282.5 96 256 96C229.5 96 208 74.51 208 48C208 21.49 229.5 0 256 0C282.5 0 304 21.49 304 48zM304 464C304 490.5 282.5 512 256 512C229.5 512 208 490.5 208 464C208 437.5 229.5 416 256 416C282.5 416 304 437.5 304 464zM0 256C0 229.5 21.49 208 48 208C74.51 208 96 229.5 96 256C96 282.5 74.51 304 48 304C21.49 304 0 282.5 0 256zM512 256C512 282.5 490.5 304 464 304C437.5 304 416 282.5 416 256C416 229.5 437.5 208 464 208C490.5 208 512 229.5 512 256zM74.98 437C56.23 418.3 56.23 387.9 74.98 369.1C93.73 350.4 124.1 350.4 142.9 369.1C161.6 387.9 161.6 418.3 142.9 437C124.1 455.8 93.73 455.8 74.98 437V437zM142.9 142.9C124.1 161.6 93.73 161.6 74.98 142.9C56.24 124.1 56.24 93.73 74.98 74.98C93.73 56.23 124.1 56.23 142.9 74.98C161.6 93.73 161.6 124.1 142.9 142.9zM369.1 369.1C387.9 350.4 418.3 350.4 437 369.1C455.8 387.9 455.8 418.3 437 437C418.3 455.8 387.9 455.8 369.1 437C350.4 418.3 350.4 387.9 369.1 369.1V369.1z", viewbox: "0 0 512 512", **options)
+    svg_icon_tag("spinner-icon animate-spin", "M304 48C304 74.51 282.5 96 256 96C229.5 96 208 74.51 208 48C208 21.49 229.5 0 256 0C282.5 0 304 21.49 304 48zM304 464C304 490.5 282.5 512 256 512C229.5 512 208 490.5 208 464C208 437.5 229.5 416 256 416C282.5 416 304 437.5 304 464zM0 256C0 229.5 21.49 208 48 208C74.51 208 96 229.5 96 256C96 282.5 74.51 304 48 304C21.49 304 0 282.5 0 256zM512 256C512 282.5 490.5 304 464 304C437.5 304 416 282.5 416 256C416 229.5 437.5 208 464 208C490.5 208 512 229.5 512 256zM74.98 437C56.23 418.3 56.23 387.9 74.98 369.1C93.73 350.4 124.1 350.4 142.9 369.1C161.6 387.9 161.6 418.3 142.9 437C124.1 455.8 93.73 455.8 74.98 437V437zM142.9 142.9C124.1 161.6 93.73 161.6 74.98 142.9C56.24 124.1 56.24 93.73 74.98 74.98C93.73 56.23 124.1 56.23 142.9 74.98C161.6 93.73 161.6 124.1 142.9 142.9zM369.1 369.1C387.9 350.4 418.3 350.4 437 369.1C455.8 387.9 455.8 418.3 437 437C418.3 455.8 387.9 455.8 369.1 437C350.4 418.3 350.4 387.9 369.1 369.1V369.1z", viewbox: "0 0 512 512", **options)
   end
 
   def external_link_icon(**options)
diff --git a/app/views/upload_media_assets/_preview.html.erb b/app/views/upload_media_assets/_preview.html.erb
index 39bf51150..dcb65e1c6 100644
--- a/app/views/upload_media_assets/_preview.html.erb
+++ b/app/views/upload_media_assets/_preview.html.erb
@@ -5,7 +5,7 @@
     <% if upload_media_asset.failed? %>
       Failed
     <% else %>
-      <%= spinner_icon(class: "animate-spin h-8") %>
+      <%= spinner_icon(class: "h-8") %>
     <% end %>
   <% end %>