jaculabilis/danbooru
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Fix #5013: BUR model doesn't validate tags.

Browse Source 
Don't allow users to request aliases, implications, or renames for invalid tag names.

As a side effect, it's no longer possible to request shortcut aliases like
`/hr -> hakurei_reimu` (slash abbreviations still exist, but they can't
be overridden with aliases). Tests involving these types of aliases are
removed.
This commit is contained in:
evazion
2022-04-30 19:25:18 -05:00
parent 0920d2ca24
commit ccd0dde081
10 changed files with 66 additions and 31 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
app/logical/bulk_update_request_processor.rb
View File

@@ -112,11 +112,15 @@ class BulkUpdateRequestProcessor
end
when :rename
tag = Tag.find_by_name(args[0])
if tag.nil?
old_tag = Tag.find_by_name(args[0])
new_tag = Tag.find_by_name(args[1]) || Tag.new(name: args[1])
if old_tag.nil?
errors.add(:base, "Can't rename #{args[0]} -> #{args[1]} (the '#{args[0]}' tag doesn't exist)")
elsif tag.post_count > MAXIMUM_RENAME_COUNT
elsif old_tag.post_count > MAXIMUM_RENAME_COUNT
errors.add(:base, "Can't rename #{args[0]} -> #{args[1]} ('#{args[0]}' has more than #{MAXIMUM_RENAME_COUNT} posts, use an alias instead)")
elsif new_tag.invalid?(:name)
errors.add(:base, "Can't rename #{args[0]} -> #{args[1]} (#{new_tag.errors.full_messages.join("; ")})")
end
when :mass_update