jaculabilis/danbooru
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

posts: remove 'Similar' button from post edit form.

Browse Source 
Remove the 'Similar' button next to the source field in the post edit
form. Removed for multiple reasons:

* It doesn't make sense to have to open the edit form to do a reverse
  image search.

* The 'Similar' button tries to redownload the file from the source,
  which has various problems: the source might have been deleted, it
  might have been changed or revised, it might be a format that iqdb
  can't handle (ugoira/webm/mp4), or it might otherwise not match the
  the actual post.

* The 'Find similar' button already exists in the sidebar and it does
  the right thing by using the preview image from Danbooru, which
  avoids all the above issues.
This commit is contained in:
evazion
2019-10-14 21:16:04 -05:00
parent f6b73a5150
commit ccf32aa7a4
2 changed files with 2 additions and 17 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
app/javascript/src/javascripts/posts.js.erb
View File

@@ -30,7 +30,6 @@ Post.initialize_all = function() {
this.initialize_post_sections();
this.initialize_post_image_resize_links();
this.initialize_post_image_resize_to_window_link();
this.initialize_similar();
if (CurrentUser.data("always-resize-images") || (Utility.meta("viewport") && (window.screen.width <= 660))) {
$("#image-resize-to-window-link").click();
@@ -171,13 +170,6 @@ Post.close_edit_dialog = function(e, ui) {
$(document).trigger("danbooru:close-post-edit-dialog");
}
Post.initialize_similar = function() {
$("#similar-button").on("click.danbooru", function(e) {
$.get("/iqdb_queries", {"url": $("#post_source").val()}).done(function(html) {$("#iqdb-similar").html(html).show()});
e.preventDefault();
});
}
Post.swipe_prev = function(e) {
if ($(".paginator a[rel~=prev]").length) {
location.href = $("a[rel~=prev]").attr("href");