search: allow mods to search disapproved:<user> for other users.

Allow moderators to search `disapproved:<username>` with any user.
Before mods could only search for their own disapprovals, even though
they could see disapprovals by others.
This commit is contained in:
evazion
2021-09-01 01:03:44 -05:00
parent c41e3f4590
commit d00aa847ae
2 changed files with 22 additions and 14 deletions

View File

@@ -874,22 +874,31 @@ class PostQueryBuilderTest < ActiveSupport::TestCase
end
should "return posts for a disapproved:<type> metatag" do
CurrentUser.scoped(create(:mod_user)) do
pending = create(:post, is_pending: true)
disapproved = create(:post, is_pending: true)
disapproval = create(:post_disapproval, user: CurrentUser.user, post: disapproved, reason: "disinterest")
disapprover = create(:user)
pending = create(:post, is_pending: true)
disapproved = create(:post, is_pending: true)
disapproval = create(:post_disapproval, user: disapprover, post: disapproved, reason: "disinterest")
assert_tag_match([disapproved], "disapproved:#{CurrentUser.user.name}")
assert_tag_match([disapproved], "disapproved:#{CurrentUser.user.name.upcase}")
as(disapprover) do
assert_tag_match([disapproved], "disapproved:#{disapprover.name}")
assert_tag_match([disapproved], "disapproved:#{disapprover.name.upcase}")
assert_tag_match([disapproved], "disapproved:disinterest")
assert_tag_match([disapproved], "disapproved:DISINTEREST")
assert_tag_match([], "disapproved:breaks_rules")
assert_tag_match([], "disapproved:breaks_rules disapproved:disinterest")
assert_tag_match([pending], "-disapproved:#{CurrentUser.user.name}")
assert_tag_match([pending], "-disapproved:#{disapprover.name}")
assert_tag_match([pending], "-disapproved:disinterest")
assert_tag_match([disapproved, pending], "-disapproved:breaks_rules")
end
as(create(:user)) do
assert_tag_match([], "disapproved:#{disapprover.name}")
end
as(create(:mod_user)) do
assert_tag_match([disapproved], "disapproved:#{disapprover.name}")
end
end
should "return posts ordered by a particular attribute" do