search: allow mods to search disapproved:<user> for other users.

Allow moderators to search `disapproved:<username>` with any user.
Before mods could only search for their own disapprovals, even though
they could see disapprovals by others.

app/logical/post_query_builder.rb

@@ -321,10 +321,9 @@ class PostQueryBuilder
   def disapproved_matches(query)
     if query.downcase.in?(PostDisapproval::REASONS)
       Post.where(disapprovals: PostDisapproval.where(reason: query.downcase))
-    elsif User.normalize_name(query) == current_user.name
-      Post.where(disapprovals: PostDisapproval.where(user: current_user))
     else
-      Post.none
+      user = User.find_by_name(query)
+      Post.where(disapprovals: PostDisapproval.creator_matches(user, current_user))
     end
   end
 
@@ -949,7 +948,7 @@ class PostQueryBuilder
       metatags.any? do |metatag|
         metatag.name.in?(%w[upvoter upvote downvoter downvote search flagger fav ordfav favgroup ordfavgroup]) ||
         metatag.name == "status" && metatag.value == "unmoderated" ||
-        metatag.name == "disapproved" && User.normalize_name(metatag.value) == current_user.name
+        metatag.name == "disapproved" && !metatag.value.downcase.in?(PostDisapproval::REASONS)
       end
     end
   end

test/unit/post_query_builder_test.rb

@@ -874,22 +874,31 @@ class PostQueryBuilderTest < ActiveSupport::TestCase
     end
 
     should "return posts for a disapproved:<type> metatag" do
-      CurrentUser.scoped(create(:mod_user)) do
+      disapprover = create(:user)
-        pending     = create(:post, is_pending: true)
+      pending     = create(:post, is_pending: true)
-        disapproved = create(:post, is_pending: true)
+      disapproved = create(:post, is_pending: true)
-        disapproval = create(:post_disapproval, user: CurrentUser.user, post: disapproved, reason: "disinterest")
+      disapproval = create(:post_disapproval, user: disapprover, post: disapproved, reason: "disinterest")
 
-        assert_tag_match([disapproved], "disapproved:#{CurrentUser.user.name}")
+      as(disapprover) do
-        assert_tag_match([disapproved], "disapproved:#{CurrentUser.user.name.upcase}")
+        assert_tag_match([disapproved], "disapproved:#{disapprover.name}")
+        assert_tag_match([disapproved], "disapproved:#{disapprover.name.upcase}")
         assert_tag_match([disapproved], "disapproved:disinterest")
         assert_tag_match([disapproved], "disapproved:DISINTEREST")
         assert_tag_match([], "disapproved:breaks_rules")
         assert_tag_match([], "disapproved:breaks_rules disapproved:disinterest")
 
-        assert_tag_match([pending], "-disapproved:#{CurrentUser.user.name}")
+        assert_tag_match([pending], "-disapproved:#{disapprover.name}")
         assert_tag_match([pending], "-disapproved:disinterest")
         assert_tag_match([disapproved, pending], "-disapproved:breaks_rules")
       end
+
+      as(create(:user)) do
+        assert_tag_match([], "disapproved:#{disapprover.name}")
+      end
+
+      as(create(:mod_user)) do
+        assert_tag_match([disapproved], "disapproved:#{disapprover.name}")
+      end
     end
 
     should "return posts ordered by a particular attribute" do