jaculabilis/danbooru
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

BURs: fix tag nukes not removing antecedent implications.

Browse Source 
Fix a bug where if A implied B, and A was nuked, then the A->B
implication wasn't removed.
This commit is contained in:
evazion
2021-09-06 00:24:14 -05:00
parent 4dcfd1d141
commit d03b150180
2 changed files with 6 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
app/logical/bulk_update_request_processor.rb
View File

@@ -158,6 +158,7 @@ class BulkUpdateRequestProcessor
# otherwise the tag won't be removed from posts that have those other tags # otherwise the tag won't be removed from posts that have those other tags
if PostQueryBuilder.new(args[0]).is_simple_tag? if PostQueryBuilder.new(args[0]).is_simple_tag?
TagImplication.active.where(consequent_name: args[0]).each { |ti| ti.reject!(User.system) } TagImplication.active.where(consequent_name: args[0]).each { |ti| ti.reject!(User.system) }
TagImplication.active.where(antecedent_name: args[0]).each { |ti| ti.reject!(User.system) }
end end
TagBatchChangeJob.perform_later(args[0], "-#{args[0]}") TagBatchChangeJob.perform_later(args[0], "-#{args[0]}")

8
test/unit/bulk_update_request_test.rb
View File

@@ -327,10 +327,12 @@ class BulkUpdateRequestTest < ActiveSupport::TestCase
end end
should "remove implications" do should "remove implications" do
@ti = create(:tag_implication, antecedent_name: "foo", consequent_name: "bar") @ti1 = create(:tag_implication, antecedent_name: "fly", consequent_name: "insect")
create_bur!("nuke bar", @admin) @ti2 = create(:tag_implication, antecedent_name: "insect", consequent_name: "bug")
create_bur!("nuke insect", @admin)
assert_equal("deleted", @ti.reload.status) assert_equal("deleted", @ti1.reload.status)
assert_equal("deleted", @ti2.reload.status)
end end
should "remove pools" do should "remove pools" do