From d0d3da08e522299078ab543c449a4b65b9e0569f Mon Sep 17 00:00:00 2001
From: evazion <noizave@gmail.com>
Date: Thu, 9 Jan 2020 16:55:09 -0600
Subject: [PATCH] views: remove IP addresses from most pages.

Removed IP addresses from comments and from most other listing pages.
IPs take up a lot of space in many places (especially IPv6 addresses),
and in most of these pages they're rarely useful for catching
sockpuppets.
---
 app/views/artist_commentary_versions/_listing.html.erb | 5 -----
 app/views/artist_versions/_listing.html.erb            | 3 ---
 app/views/comments/partials/show/_comment.html.erb     | 7 -------
 app/views/dmails/show.html.erb                         | 3 ---
 app/views/maintenance/user/dmail_filters/edit.html.erb | 3 ---
 app/views/note_versions/_listing.html.erb              | 5 -----
 app/views/pool_versions/_listing.html.erb              | 5 -----
 app/views/post_versions/_listing.html.erb              | 3 ---
 app/views/wiki_page_versions/_global_listing.html.erb  | 3 ---
 app/views/wiki_page_versions/_page_listing.html.erb    | 3 ---
 10 files changed, 40 deletions(-)

diff --git a/app/views/artist_commentary_versions/_listing.html.erb b/app/views/artist_commentary_versions/_listing.html.erb
index 38e100b20..f1963eed1 100644
--- a/app/views/artist_commentary_versions/_listing.html.erb
+++ b/app/views/artist_commentary_versions/_listing.html.erb
@@ -21,11 +21,6 @@
       <%= format_commentary_title(commentary_version.translated_title) %>
       <%= format_commentary_description(commentary_version.translated_description) %>
     <% end %>
-    <% if CurrentUser.is_moderator? %>
-      <% t.column "IP Address", {width: "10%"} do |commentary_version| %>
-        <%= link_to_ip commentary_version.updater_ip_addr %>
-      <% end %>
-    <% end %>
     <% t.column "Edited by", {width: "10%"} do |commentary_version| %>
       <%= link_to_user commentary_version.updater %>
     <% end %>
diff --git a/app/views/artist_versions/_listing.html.erb b/app/views/artist_versions/_listing.html.erb
index 1b328d9bd..8833baa9a 100644
--- a/app/views/artist_versions/_listing.html.erb
+++ b/app/views/artist_versions/_listing.html.erb
@@ -28,9 +28,6 @@
         <%= link_to "»", artist_versions_path(search: { updater_name: artist_version.updater.name }) %>
         <p>
           <%= compact_time(artist_version.updated_at) %>
-          <% if CurrentUser.is_moderator? %>
-            (<%= link_to_ip artist_version.updater_ip_addr %>)
-          <% end %>
         </p>
       <% end %>
       <% if artist_versions_listing_type == :revert %>
diff --git a/app/views/comments/partials/show/_comment.html.erb b/app/views/comments/partials/show/_comment.html.erb
index a5cd60b52..f08b42014 100644
--- a/app/views/comments/partials/show/_comment.html.erb
+++ b/app/views/comments/partials/show/_comment.html.erb
@@ -53,13 +53,6 @@
           <li class="comment-unvote-link">
             <%= link_to "Unvote", comment_comment_votes_path(comment_id: comment.id), method: :delete, remote: true %>
           </li>
-          <% if CurrentUser.is_moderator? %>
-            <li>|</li>
-            <li>
-              <strong>IP</strong>
-              <span><%= link_to_ip comment.creator_ip_addr %></span>
-            </li>
-          <% end %>
         </menu>
         <% if comment.editable_by?(CurrentUser.user) %>
           <%= render "comments/form", comment: comment, hidden: true %>
diff --git a/app/views/dmails/show.html.erb b/app/views/dmails/show.html.erb
index 6e1c48992..9d092b02c 100644
--- a/app/views/dmails/show.html.erb
+++ b/app/views/dmails/show.html.erb
@@ -8,9 +8,6 @@
         <li><strong>Sender</strong>: <%= link_to_user @dmail.from %></li>
         <li><strong>Recipient</strong>: <%= link_to_user @dmail.to %></li>
         <li><strong>Date</strong>: <%= compact_time(@dmail.created_at) %></li>
-        <% if CurrentUser.user.is_moderator? %>
-          <li><strong>Sender IP</strong>: <%= link_to_ip @dmail.creator_ip_addr %></li>
-        <% end %>
       </ul>
 
       <h3>Body</h3>
diff --git a/app/views/maintenance/user/dmail_filters/edit.html.erb b/app/views/maintenance/user/dmail_filters/edit.html.erb
index f7bed1813..1a0644c67 100644
--- a/app/views/maintenance/user/dmail_filters/edit.html.erb
+++ b/app/views/maintenance/user/dmail_filters/edit.html.erb
@@ -9,9 +9,6 @@
         <li><strong>Sender</strong>: <%= link_to_user @dmail.from %></li>
         <li><strong>Recipient</strong>: <%= link_to_user @dmail.to, :raw => true %></li>
         <li><strong>Date</strong>: <%= compact_time(@dmail.created_at) %></li>
-        <% if CurrentUser.user.is_moderator? %>
-          <li><strong>Sender IP</strong>: <%= link_to_ip @dmail.creator_ip_addr %></li>
-        <% end %>
       </ul>
 
       <h3>Body</h3>
diff --git a/app/views/note_versions/_listing.html.erb b/app/views/note_versions/_listing.html.erb
index 132c4f1cf..2b920c0ac 100644
--- a/app/views/note_versions/_listing.html.erb
+++ b/app/views/note_versions/_listing.html.erb
@@ -24,11 +24,6 @@
       <% t.column "Position", {width: "5%"} do |note_version| %>
         <%= note_version_position_diff(note_version) %>
       <% end %>
-      <% if CurrentUser.is_moderator? %>
-        <% t.column "IP Address", {width: "10%"} do |note_version| %>
-          <%= link_to_ip note_version.updater_ip_addr %>
-        <% end %>
-      <% end %>
       <% t.column "Edited By", {width: "10%"} do |note_version| %>
         <%= link_to_user note_version.updater %>
       <% end %>
diff --git a/app/views/pool_versions/_listing.html.erb b/app/views/pool_versions/_listing.html.erb
index a4ef76d2e..6dfed97a8 100644
--- a/app/views/pool_versions/_listing.html.erb
+++ b/app/views/pool_versions/_listing.html.erb
@@ -23,11 +23,6 @@
           <%= link_to "»", pool_versions_path(search: { updater_id: pool_version.updater_id }) %>
         <% end %>
       <% end %>
-      <% if CurrentUser.is_moderator? %>
-        <% t.column "IP Address" do |pool_version| %>
-          <%= link_to_ip pool_version.updater_ip_addr %>
-        <% end %>
-      <% end %>
       <% t.column "Date" do |pool_version| %>
         <%= compact_time pool_version.updated_at %>
       <% end %>
diff --git a/app/views/post_versions/_listing.html.erb b/app/views/post_versions/_listing.html.erb
index 13eff5c82..54d45b545 100644
--- a/app/views/post_versions/_listing.html.erb
+++ b/app/views/post_versions/_listing.html.erb
@@ -25,9 +25,6 @@
         <%= link_to "»", post_versions_path(search: params[:search].merge({ updater_name: post_version.updater&.name })) %>
         <div>
           <%= compact_time(post_version.updated_at) %>
-          <% if CurrentUser.is_moderator? %>
-            (<%= link_to_ip post_version.updater_ip_addr %>)
-          <% end %>
         </div>
       <% end %>
       <% t.column do |post_version| %>
diff --git a/app/views/wiki_page_versions/_global_listing.html.erb b/app/views/wiki_page_versions/_global_listing.html.erb
index 108a0e36b..eb8bbab59 100644
--- a/app/views/wiki_page_versions/_global_listing.html.erb
+++ b/app/views/wiki_page_versions/_global_listing.html.erb
@@ -18,9 +18,6 @@
       <%= compact_time(wiki_page_version.updated_at) %>
       by
       <%= link_to_user wiki_page_version.updater %>
-      <% if CurrentUser.is_moderator? %>
-        (<%= link_to_ip wiki_page_version.updater_ip_addr %>)
-      <% end %>
       <%= link_to "»", wiki_page_versions_path(search: { updater_id: wiki_page_version.updater.id }) %>
     <% end %>
   <% end %>
diff --git a/app/views/wiki_page_versions/_page_listing.html.erb b/app/views/wiki_page_versions/_page_listing.html.erb
index 292ff6729..d6cdca475 100644
--- a/app/views/wiki_page_versions/_page_listing.html.erb
+++ b/app/views/wiki_page_versions/_page_listing.html.erb
@@ -28,9 +28,6 @@
         <%= compact_time(wiki_page_version.updated_at) %>
         by
         <%= link_to_user wiki_page_version.updater %>
-        <% if CurrentUser.is_moderator? %>
-          (<%= link_to_ip wiki_page_version.updater_ip_addr %>)
-        <% end %>
         <%= link_to "»", wiki_page_versions_path(search: { updater_id: wiki_page_version.updater.id }) %>
       <% end %>
     <% end %>