application record: drop execute_sql, select_value_sql methods.

test/unit/note_test.rb

@@ -33,13 +33,10 @@ class NoteTest < ActiveSupport::TestCase
       end
 
       context "when the note is deleted the post" do
-        setup do
-          @note.toggle!(:is_active)
-        end
-
         should "null out its last_noted_at_field" do
-          @post.reload
-          assert_nil(@post.last_noted_at)
+          assert_not_nil(@post.reload.last_noted_at)
+          @note.update!(is_active: false)
+          assert_nil(@post.reload.last_noted_at)
         end
       end
     end
@@ -127,10 +124,9 @@ class NoteTest < ActiveSupport::TestCase
       end
 
       should "update the post's last_noted_at field" do
-        assert_nil(@post.last_noted_at)
-        @note.update(x: 500)
-        @post.reload
-        assert_equal(@post.last_noted_at.to_i, @note.updated_at.to_i)
+        assert_equal(@post.reload.last_noted_at.to_i, @note.updated_at.to_i)
+        assert_changes("@post.reload.last_noted_at") { @note.update(x: 500) }
+        assert_equal(@post.reload.last_noted_at.to_i, @note.reload.updated_at.to_i)
       end
 
       should "create a version" do

test/unit/pool_test.rb

@@ -20,36 +20,6 @@ class PoolTest < ActiveSupport::TestCase
     CurrentUser.ip_addr = nil
   end
 
-  context "A name" do
-    setup do
-      @pool = FactoryBot.create(:pool, :name => "xxx")
-    end
-
-    should "be mapped to a pool id" do
-      assert_equal(@pool.id, Pool.name_to_id("xxx"))
-    end
-  end
-
-  context "A multibyte character name" do
-    setup do
-      @mb_pool = FactoryBot.create(:pool, :name => "àáâãäå")
-    end
-
-    should "be mapped to a pool id" do
-      assert_equal(@mb_pool.id, Pool.name_to_id("àáâãäå"))
-    end
-  end
-
-  context "An id number" do
-    setup do
-      @pool = FactoryBot.create(:pool)
-    end
-
-    should "be mapped to a pool id" do
-      assert_equal(@pool.id, Pool.name_to_id(@pool.id.to_s))
-    end
-  end
-
   context "Searching pools" do
     should "find pools by name" do
       @pool = FactoryBot.create(:pool, name: "Test Pool")