favoritescontroller#destroy should work even if the post doesn't exist, remove from favorites on expunge (fixes #3222)

2017-07-19 13:22:24 -07:00
parent 5d013f9c88
commit d48ed95191
7 changed files with 50 additions and 21 deletions
--- a/test/unit/user_deletion_test.rb
+++ b/test/unit/user_deletion_test.rb
@@ -40,7 +40,7 @@ class UserDeletionTest < ActiveSupport::TestCase
      CurrentUser.ip_addr = "127.0.0.1"

      @post = FactoryGirl.create(:post)
-      Favorite.add(@post, @user)
+      Favorite.add(post: @post, user: @user)

      @user.update_attributes(:email => "ted@danbooru.com")