From d4b9b66c0e46a015278f4897aff6cc9f4e5c35d9 Mon Sep 17 00:00:00 2001 From: evazion Date: Thu, 2 Mar 2017 16:59:25 -0600 Subject: [PATCH] post_versions_controller.rb: fix N+1 queries in post, updater. Rendering the updater name at post_versions/_listing.html:25 caused this for each post version: SELECT "users".* FROM "users" WHERE "users"."id" = $1 LIMIT 1 PostArchive#diff caused this for each post version: SELECT "posts".* FROM "posts" WHERE "posts"."id" = $1 LIMIT 1 --- app/controllers/post_versions_controller.rb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/app/controllers/post_versions_controller.rb b/app/controllers/post_versions_controller.rb index ade388b63..71943d97a 100644 --- a/app/controllers/post_versions_controller.rb +++ b/app/controllers/post_versions_controller.rb @@ -3,7 +3,7 @@ class PostVersionsController < ApplicationController respond_to :html, :xml, :json def index - @post_versions = PostArchive.search(params[:search]).order("updated_at desc, id desc").paginate(params[:page], :limit => params[:limit], :search_count => params[:search]) + @post_versions = PostArchive.includes(:post, :updater).search(params[:search]).order("updated_at desc, id desc").paginate(params[:page], :limit => params[:limit], :search_count => params[:search]) respond_with(@post_versions) do |format| format.xml do render :xml => @post_versions.to_xml(:root => "post-versions")