Nicoseiga: rewrite tests and fix several bugs

* Fixed a bug where manga posts with a single tag would raise an error
* Fixed a bug where dic.nicovideo.jp/oekaki posts weren't uploadable due
  to SSL issues
* Added support for more manga corner cases
This commit is contained in:
nonamethanks
2022-09-29 00:46:47 +02:00
committed by N. Oname
parent d629c81aa1
commit d51cc17eaf
6 changed files with 212 additions and 179 deletions

View File

@@ -19,12 +19,7 @@ class NicoSeigaApiClient
when "illust"
[api_response["id"]]
when "manga"
manga_api_response.map do |x|
case x["meta"]["source_url"]
when %r{/thumb/(\d+)\w}i then Regexp.last_match(1)
when %r{nicoseiga\.cdn\.nimg\.jp/drm/image/\w+/(\d+)\w}i then Regexp.last_match(1)
end
end
manga_api_response.map { |x| Source::URL.parse(x.dig("meta", "source_url"))&.image_id }.compact
end
end
@@ -37,11 +32,21 @@ class NicoSeigaApiClient
end
def tags
api_response.dig("tag_list", "tag").to_a.map { |t| t["name"] }.compact
tags = api_response.dig("tag_list", "tag")
if tags.instance_of? Hash
# When a manga post has a single tag, the XML parser thinks it's a hash instead of an array of hashes,
# so we need to manually turn it into the latter. Example: https://seiga.nicovideo.jp/watch/mg302561
tags = [tags]
end
tags.to_a.map { |t| t["name"] }.compact
end
def user_id
api_response["user_id"]
if api_response["user_id"].to_i == 0 # anonymous: https://nico.ms/mg310193
nil
else
api_response["user_id"]
end
end
def user_name
@@ -80,6 +85,7 @@ class NicoSeigaApiClient
end
def user_api_response(user_id)
return {} unless user_id.present?
resp = get("#{XML_API}/user/info?id=#{user_id}")
return {} if resp.blank? || resp.code.to_i == 404
Hash.from_xml(resp.to_s)["response"]["user"]