add secondary validations to aliases+implications+requests

test/unit/tag_alias_request_test.rb

@@ -16,28 +16,37 @@ class TagAliasRequestTest < ActiveSupport::TestCase
       CurrentUser.ip_addr = nil
     end
 
-    should "raise an exception if invalid" do
-      assert_raises(TagAliasRequest::ValidationError) do
-        TagAliasRequest.new("", "", "reason").create
-      end
+    should "handle invalid attributes" do
+      tar = TagAliasRequest.new(:antecedent_name => "", :consequent_name => "", :reason => "reason", :skip_secondary_validations => true)
+      tar.create
+      assert(tar.invalid?)
+    end
+
+    should "handle secondary validations" do
+      tar = TagAliasRequest.new(:antecedent_name => "aaa", :consequent_name => "bbb", :reason => "reason", :skip_secondary_validations => false)
+      tar.create
+      assert(tar.invalid?)
     end
 
     should "create a tag alias" do
       assert_difference("TagAlias.count", 1) do
-        TagAliasRequest.new("aaa", "bbb", "reason").create
+        tar = TagAliasRequest.new(:antecedent_name => "aaa", :consequent_name => "bbb", :reason => "reason", :skip_secondary_validations => true)
+        tar.create
       end
       assert_equal("pending", TagAlias.last.status)
     end
 
     should "create a forum topic" do
       assert_difference("ForumTopic.count", 1) do
-        TagAliasRequest.new("aaa", "bbb", "reason").create
+        tar = TagAliasRequest.new(:antecedent_name => "aaa", :consequent_name => "bbb", :reason => "reason", :skip_secondary_validations => true)
+        tar.create
       end
     end
 
     should "create a forum post" do
       assert_difference("ForumPost.count", 1) do
-        TagAliasRequest.new("aaa", "bbb", "reason").create
+        tar = TagAliasRequest.new(:antecedent_name => "aaa", :consequent_name => "bbb", :reason => "reason", :skip_secondary_validations => true)
+        tar.create
       end
     end
   end

test/unit/tag_implication_request_test.rb

@@ -16,28 +16,37 @@ class TagImplicationRequestTest < ActiveSupport::TestCase
       CurrentUser.ip_addr = nil
     end
 
-    should "raise an exception if invalid" do
-      assert_raises(TagImplicationRequest::ValidationError) do
-        TagImplicationRequest.new("", "", "reason").create
-      end
+    should "handle invalid attributes" do
+      tir = TagImplicationRequest.new(:antecedent_name => "", :consequent_name => "", :reason => "reason", :skip_secondary_validations => true)
+      tir.create
+      assert(tir.invalid?)
+    end
+
+    should "handle secondary validations" do
+      tir = TagImplicationRequest.new(:antecedent_name => "aaa", :consequent_name => "bbb", :reason => "reason", :skip_secondary_validations => false)
+      tir.create
+      assert(tir.invalid?)
     end
 
     should "create a tag implication" do
       assert_difference("TagImplication.count", 1) do
-        TagImplicationRequest.new("aaa", "bbb", "reason").create
+        tir = TagImplicationRequest.new(:antecedent_name => "aaa", :consequent_name => "bbb", :reason => "reason", :skip_secondary_validations => true)
+        tir.create
       end
       assert_equal("pending", TagImplication.last.status)
     end
 
     should "create a forum topic" do
       assert_difference("ForumTopic.count", 1) do
-        TagImplicationRequest.new("aaa", "bbb", "reason").create
+        tir = TagImplicationRequest.new(:antecedent_name => "aaa", :consequent_name => "bbb", :reason => "reason", :skip_secondary_validations => true)
+        tir.create
       end
     end
 
     should "create a forum post" do
       assert_difference("ForumPost.count", 1) do
-        TagImplicationRequest.new("aaa", "bbb", "reason").create
+        tir = TagImplicationRequest.new(:antecedent_name => "aaa", :consequent_name => "bbb", :reason => "reason", :skip_secondary_validations => true)
+        tir.create
       end
     end
   end