jaculabilis/danbooru
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

/dmails: remove unused search[owner_id] param.

Browse Source 
/dmails is restricted to viewing dmails for CurrentUser only (due to
Dmail.visible in the index action). Remove owner_id from subnavbar links
in /dmails, and don't support it in /dmails?search[owner_id], since it
doesn't actually do anything.

Also removes related dead methods and fixes tests that didn't test owner_id properly.
This commit is contained in:
evazion
2017-02-23 20:23:33 -06:00
parent 6de350cd7d
commit d852f98e4f
5 changed files with 28 additions and 26 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
test/factories/post_disapproval.rb Normal file
View File

@@ -0,0 +1,6 @@
FactoryGirl.define do
factory(:post_disapproval) do
reason { %w(breaks_rules poor_quality disinterest).sample }
message { FFaker::Lorem.sentence }
end
end

6
test/functional/dmails_controller_test.rb
View File

@@ -48,17 +48,17 @@ class DmailsControllerTest < ActionController::TestCase
context "index action" do
should "show dmails owned by the current user" do
get :index, {:owner_id_equals => @dmail.owner_id, :folder => "sent"}, {:user_id => @dmail.owner_id}
get :index, {:search => {:owner_id => @dmail.owner_id, :folder => "sent"}}, {:user_id => @dmail.owner_id}
assert_response :success
assert_equal(1, assigns[:dmails].size)
get :index, {:owner_id_equals => @dmail.owner_id, :folder => "received"}, {:user_id => @dmail.owner_id}
get :index, {:search => {:owner_id => @dmail.owner_id, :folder => "received"}}, {:user_id => @dmail.owner_id}
assert_response :success
assert_equal(1, assigns[:dmails].size)
end
should "not show dmails not owned by the current user" do
get :index, {:owner_id_equals => @dmail.owner_id}, {:user_id => @unrelated_user.id}
get :index, {:search => {:owner_id => @dmail.owner_id}}, {:user_id => @unrelated_user.id}
assert_response :success
assert_equal(0, assigns[:dmails].size)
end