From ded03df1ff5ab3331997a0f4329b3f4ab2c0dcd3 Mon Sep 17 00:00:00 2001 From: evazion Date: Tue, 15 Mar 2022 05:04:11 -0500 Subject: [PATCH] tests: fix more broken tests. --- app/logical/source/url/nico_seiga.rb | 2 +- test/unit/artist_url_test.rb | 4 ++-- test/unit/downloads/pixiv_test.rb | 11 ----------- 3 files changed, 3 insertions(+), 14 deletions(-) diff --git a/app/logical/source/url/nico_seiga.rb b/app/logical/source/url/nico_seiga.rb index 1b0a798f6..4b563f473 100644 --- a/app/logical/source/url/nico_seiga.rb +++ b/app/logical/source/url/nico_seiga.rb @@ -98,7 +98,7 @@ module Source # http://sp.seiga.nicovideo.jp/manga/list?user_id=23839737 in /seiga\.nicovideo\.jp$/, "manga", "list" if params[:user_id].present? @user_id = params[:user_id] - @profile_url = "https://seiga.nicovideo.jp/manga/list?user_id=#{user_id}" + @profile_url = "https://seiga.nicovideo.jp/manga/list?user_id=#{params[:user_id]}" # https://www.nicovideo.jp/user/4572975 # https://www.nicovideo.jp/user/20446930/mylist/28674289 diff --git a/test/unit/artist_url_test.rb b/test/unit/artist_url_test.rb index 938fb4657..e3593ad6f 100644 --- a/test/unit/artist_url_test.rb +++ b/test/unit/artist_url_test.rb @@ -90,10 +90,10 @@ class ArtistURLTest < ActiveSupport::TestCase assert_equal("http://seiga.nicovideo.jp/user/illust/7017777/", url.normalized_url) url = create(:artist_url, url: "http://seiga.nicovideo.jp/manga/list?user_id=23839737") - assert_equal("http://seiga.nicovideo.jp/user/illust/23839737/", url.normalized_url) + assert_equal("http://seiga.nicovideo.jp/manga/list?user_id=23839737/", url.normalized_url) url = create(:artist_url, url: "https://www.nicovideo.jp/user/20446930/mylist/28674289") - assert_equal("http://seiga.nicovideo.jp/user/illust/20446930/", url.normalized_url) + assert_equal("http://www.nicovideo.jp/user/20446930/", url.normalized_url) end should "normalize hentai foundry artist urls" do diff --git a/test/unit/downloads/pixiv_test.rb b/test/unit/downloads/pixiv_test.rb index f24261a14..a23d09906 100644 --- a/test/unit/downloads/pixiv_test.rb +++ b/test/unit/downloads/pixiv_test.rb @@ -53,17 +53,6 @@ module Downloads assert_downloaded(@p1_file_size, @p1_full_size_image) end - should "download the full size image instead of the HTML page" do - skip "Pixiv credentials not configured" unless Sources::Strategies::Pixiv.enabled? - - assert_rewritten(@p0_full_size_image, @medium_page) - assert_rewritten(@p0_full_size_image, @manga_page) - assert_rewritten(@p0_full_size_image, @manga_big_p1_page) - assert_downloaded(@p0_file_size, @medium_page) - assert_downloaded(@p0_file_size, @manga_page) - assert_downloaded(@p0_file_size, @manga_big_p1_page) - end - should "download the full size image instead of the thumbnail" do skip "Pixiv credentials not configured" unless Sources::Strategies::Pixiv.enabled?