From e33d6f9e84ac710bd42b6bc1ec0d19d42755ef4d Mon Sep 17 00:00:00 2001 From: evazion Date: Sat, 25 Aug 2018 11:12:37 -0500 Subject: [PATCH] Post#is_approvable?: fix 'Approve' link appearing on approver's own uploads. Fixes the 'Approve' link in the modqueue and in the quickmod bar being shown as available on the approver's own flagged uploads, even though they can't actually approve these posts. --- app/models/post.rb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/app/models/post.rb b/app/models/post.rb index 766beeef6..6fa11d74d 100644 --- a/app/models/post.rb +++ b/app/models/post.rb @@ -289,7 +289,7 @@ class Post < ApplicationRecord module ApprovalMethods def is_approvable?(user = CurrentUser.user) - !is_status_locked? && (is_pending? || is_flagged? || is_deleted?) && !approved_by?(user) + !is_status_locked? && (is_pending? || is_flagged? || is_deleted?) && uploader != user && !approved_by?(user) end def flag!(reason, options = {})