better validation for bulk update requests

This commit is contained in:
r888888888
2016-01-28 17:39:01 -08:00
parent b8f14b6fee
commit e6b16e8fe5
7 changed files with 98 additions and 3 deletions

View File

@@ -10,6 +10,7 @@ class BulkUpdateRequest < ActiveRecord::Base
validates_inclusion_of :status, :in => %w(pending approved rejected)
validate :script_formatted_correctly
validate :forum_topic_id_not_invalid
validate :validate_script
attr_accessible :user_id, :forum_topic_id, :script, :title, :reason
attr_accessible :status, :as => [:admin]
before_validation :initialize_attributes, :on => :create
@@ -130,7 +131,6 @@ class BulkUpdateRequest < ActiveRecord::Base
end
end
def update_forum_topic_for_approve
if forum_topic
forum_topic.posts.create(
@@ -150,4 +150,15 @@ class BulkUpdateRequest < ActiveRecord::Base
def normalize_text
self.script = script.downcase
end
def validate_script
begin
AliasAndImplicationImporter.new(script, forum_topic_id, "1").validate!
rescue RuntimeError => e
self.errors[:base] = e.message
return false
end
errors.empty?
end
end