jaculabilis/danbooru
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Use transaction when favoriting to prevent post from being half-favorited

Browse Source
This commit is contained in:
Toks
2014-04-11 14:50:34 -04:00
parent 57f82182a8
commit e8b92781c4
1 changed files with 22 additions and 18 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
app/models/favorite.rb
View File

@@ -12,6 +12,7 @@ class Favorite < ActiveRecord::Base
end end
def self.add(post, user) def self.add(post, user)
Favorite.transaction do
return if Favorite.for_user(user.id).where(:user_id => user.id, :post_id => post.id).exists? return if Favorite.for_user(user.id).where(:user_id => user.id, :post_id => post.id).exists?
Favorite.create(:user_id => user.id, :post_id => post.id) Favorite.create(:user_id => user.id, :post_id => post.id)
Post.update_all("fav_count = fav_count + 1", {:id => post.id}) Post.update_all("fav_count = fav_count + 1", {:id => post.id})
@@ -22,8 +23,10 @@ class Favorite < ActiveRecord::Base
# post.fav_count += 1 # this is handled in Post#clean_fav_string! # post.fav_count += 1 # this is handled in Post#clean_fav_string!
post.score += 1 if user.is_gold? post.score += 1 if user.is_gold?
end end
end
def self.remove(post, user) def self.remove(post, user)
Favorite.transaction do
return unless Favorite.for_user(user.id).where(:user_id => user.id, :post_id => post.id).exists? return unless Favorite.for_user(user.id).where(:user_id => user.id, :post_id => post.id).exists?
Favorite.destroy_all(:user_id => user.id, :post_id => post.id) Favorite.destroy_all(:user_id => user.id, :post_id => post.id)
Post.update_all("fav_count = fav_count - 1", {:id => post.id}) Post.update_all("fav_count = fav_count - 1", {:id => post.id})
@@ -34,4 +37,5 @@ class Favorite < ActiveRecord::Base
post.fav_count -= 1 post.fav_count -= 1
post.score -= 1 if user.is_gold? post.score -= 1 if user.is_gold?
end end
end
end end