From eb08c12998032581a78d2b256fd0e022cdff28ce Mon Sep 17 00:00:00 2001
From: albert <r888888888@gmail.com>
Date: Sat, 23 Feb 2013 17:14:01 -0500
Subject: [PATCH] tweaks to user profile layout

---
 .../stylesheets/specific/users.css.scss       |  25 ++--
 app/views/users/_post_summary.html.erb        |  28 ++--
 app/views/users/_statistics.html.erb          | 120 ++++++++++++------
 3 files changed, 111 insertions(+), 62 deletions(-)

diff --git a/app/assets/stylesheets/specific/users.css.scss b/app/assets/stylesheets/specific/users.css.scss
index 11c85bf97..b6d2e1dfb 100644
--- a/app/assets/stylesheets/specific/users.css.scss
+++ b/app/assets/stylesheets/specific/users.css.scss
@@ -20,16 +20,25 @@ div#c-users {
       clear: both;
     }
     
-    dl {
-      dt { 
-        width: 12em;
-        float: left;
-        clear: left;
-        margin-right: .75em;
+    table.user-statistics {
+      tr {
+        height: 1.75em;
       }
       
-      dt:after { 
-        content: ':';
+      th {
+        width: 15%;
+        text-align: right;
+        padding-right: 1em;
+        vertical-align: top;
+      }
+      
+      td {
+        width: 85%;
+        vertical-align: top;
+      }
+      
+      p {
+        margin-bottom: 0.5em;
       }
     }
   }
diff --git a/app/views/users/_post_summary.html.erb b/app/views/users/_post_summary.html.erb
index 3c670d8d1..14c366b70 100644
--- a/app/views/users/_post_summary.html.erb
+++ b/app/views/users/_post_summary.html.erb
@@ -24,22 +24,16 @@
   <% end %>
 </div>
 
-<div class="box">
-  <h2><%= link_to "Subscriptions", posts_path(:tags => "sub:#{user.name}") %></h2>
-  <% presenter.subscriptions.each do |subscription| %>
-    <div class="box">
-      <h3>
-        <%= link_to subscription.pretty_name, posts_path(:tags => "sub:#{user.name}:#{subscription.name}") %>
-        &ndash;
-        <%= presenter.tag_links_for_subscription(self, subscription) %>
-      </h3>
+<% presenter.subscriptions.each do |subscription| %>
+  <div class="box">
+    <h2>
+      Subscription: <%= link_to subscription.pretty_name, posts_path(:tags => "sub:#{user.name}:#{subscription.name}") %>
+    </h2>
 
-      <div class="box">
-        <% presenter.posts_for_subscription(subscription).each do |post| %>
-          <%= PostPresenter.preview(post) %>
-        <% end %>
-      </div>
+    <div class="box">
+      <% presenter.posts_for_subscription(subscription).each do |post| %>
+        <%= PostPresenter.preview(post) %>
+      <% end %>
     </div>
-    
-  <% end %>
-</div>
+  </div>
+<% end %>
diff --git a/app/views/users/_statistics.html.erb b/app/views/users/_statistics.html.erb
index d25ffb0d1..720ded342 100644
--- a/app/views/users/_statistics.html.erb
+++ b/app/views/users/_statistics.html.erb
@@ -1,54 +1,100 @@
 <div>
   <h2>Statistics</h2>
-  <dl>
-    <dt>Join Date</dt>
-    <dd><%= presenter.join_date %></dd>
+  <table width="100%" class="user-statistics">
+    <tbody>
+      <tr>
+        <th>Join Date</th>
+        <td><%= presenter.join_date %></td>
+      </tr>
 
-    <dt>Inviter</dt>
-    <dd><%= presenter.inviter(self) %></dd>
+      <tr>
+        <th>Inviter</th>
+        <td><%= presenter.inviter(self) %></td>
+      </tr>
 
-    <dt>Level</dt>
-    <dd><%= presenter.level %></dd>
+      <tr>
+        <th>Level</th>
+        <td><%= presenter.level %></td>
+      </tr>
 
-    <% if user.is_banned? %>
-      <dt>Ban reason</dt>
-      <dd><%= presenter.ban_reason %></dd>
-    <% end %>
+      <% if user.is_banned? %>
+        <tr>
+          <th>Ban reason</th>
+          <td><%= presenter.ban_reason %></td>
+        </tr>
+      <% end %>
 
-    <dt>Upload Limit</dt>
-    <dd><%= presenter.upload_limit %></dd>
+      <tr>
+        <th>Upload Limit</th>
+        <td><%= presenter.upload_limit %></td>
+      </tr>
 
-    <dt>Uploads</dt>
-    <dd><%= presenter.upload_count(self) %></dd>
+      <tr>
+        <th>Uploads</th>
+        <td><%= presenter.upload_count(self) %></td>
+      </tr>
+      
+      <tr>
+        <th>Deleted Uploads</th>
+        <td><%= presenter.deleted_upload_count(self) %></td>
+      </tr>
 
-    <dt>Deleted Uploads</dt>
-    <dd><%= presenter.deleted_upload_count(self) %></dd>
+      <tr>
+        <th>Favorites</th>
+        <td><%= presenter.favorite_count(self) %></td>
+      </tr>
 
-    <dt>Favorites</dt>
-    <dd><%= presenter.favorite_count(self) %></dd>
+      <tr>
+        <th>Post Changes</th>
+        <td><%= presenter.post_version_count(self) %></td>
+      </tr>
 
-    <dt>Post Changes</dt>
-    <dd><%= presenter.post_version_count(self) %></dd>
+      <tr>
+        <th>Note Changes</th>
+        <td><%= presenter.note_version_count(self) %></td>
+      </tr>
 
-    <dt>Note Changes</dt>
-    <dd><%= presenter.note_version_count(self) %></dd>
+      <tr>
+        <th>Wiki Page Changes</th>
+        <td><%= presenter.wiki_page_version_count(self) %></td>
+      </tr>
 
-    <dt>Wiki Page Changes</dt>
-    <dd><%= presenter.wiki_page_version_count(self) %></dd>
+      <tr>
+        <th>Pool Changes</th>
+        <td><%= presenter.pool_version_count(self) %></td>
+      </tr>
 
-    <dt>Pool Changes</dt>
-    <dd><%= presenter.pool_version_count(self) %></dd>
+      <tr>
+        <th>Forum Posts</th>
+        <td><%= presenter.forum_post_count(self) %></td>
+      </tr>
 
-    <dt>Forum Posts</dt>
-    <dd><%= presenter.forum_post_count(self) %></dd>
+      <tr>
+        <th>Approvals</th>
+        <td><%= presenter.approval_count(self) %></td>
+      </tr>
 
-    <dt>Approvals</dt>
-    <dd><%= presenter.approval_count(self) %></dd>
+      <tr>
+        <th>Comments</th>
+        <td><%= presenter.comment_count(self) %></td>
+      </tr>
 
-    <dt>Comments</dt>
-    <dd><%= presenter.comment_count(self) %></dd>
-
-    <dt>Feedback</dt>
-    <dd><%= presenter.feedbacks(self) %></dd>
-  </dl>
+      <tr>
+        <th>Feedback</th>
+        <td><%= presenter.feedbacks(self) %></td>    </tbody>
+      </tr>
+      
+      <tr>
+        <th>Subscriptions</th>
+        <td>
+          <% presenter.subscriptions.each do |subscription| %>
+            <p>
+              <strong><%= link_to subscription.pretty_name, posts_path(:tags => "sub:#{user.name}:#{subscription.name}") %></strong>
+              &ndash;
+              <%= presenter.tag_links_for_subscription(self, subscription) %>
+            </p>
+          <% end %>
+        </td>
+      </tr>
+  </table>
 </div>
\ No newline at end of file