jaculabilis/danbooru
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

emails: fix one-click unsubscription.

Browse Source 
Fix it so that emails are (hopefully) able to show the one-click
unsubscribe button in Gmail and other mail providers that support the
List-Unsubscribe header. This way users can unsubscribe instead of
marking emails as spam.

* Add the List-Unsubscribe-Post header.
* Fix the disable email notifications endpoint to support POST as well as DELETE requests.
* Fix the disable email notifications endpoint to disable XSRF protection (we don't need
  users to be logged in because we use a signed URL instead).

https://www.rfc-editor.org/rfc/rfc8058#section-3.1
https://www.rfc-editor.org/rfc/rfc8058#section-8.1
This commit is contained in:
evazion
2022-09-28 19:44:29 -05:00
parent 5051c6649d
commit ed9986def6
4 changed files with 34 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
test/functional/maintenance/user/email_notifications_controller.rb
View File

@@ -19,14 +19,21 @@ module Maintenance
context "#destroy" do
should "disable email notifications" do
delete_auth maintenance_user_email_notification_path(user_id: @user.id, sig: @sig), @user
delete maintenance_user_email_notification_path(user_id: @user.id, sig: @sig)
assert_response :success
assert_equal(false, @user.reload.receive_email_notifications)
end
should "disable email notifications from a one-click unsubscribe" do
post maintenance_user_email_notification_path(user_id: @user.id, sig: @sig), params: { "List-Unsubscribe": "One-Click" }
assert_response :success
assert_equal(false, @user.reload.receive_email_notifications)
end
should "not disable email notifications when given an incorrect signature" do
delete_auth maintenance_user_email_notification_path(user_id: @user.id, sig: "foo"), @user
delete maintenance_user_email_notification_path(user_id: @user.id, sig: "foo")
assert_response 403
assert_equal(true, @user.reload.receive_email_notifications)