jaculabilis/danbooru
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

users: remove 'hide deleted posts' account setting.

Browse Source 
This setting automatically added the `-status:deleted` metatag to all searches. This meant deleted
posts were filtered out at the database level, rather than at the html level. This way searches
wouldn't have less-than-full pages.

The cost was that searches were slower, mainly because post counts weren't cached. Normally when you
search for a tag, we can get the post count from the tags table. If the search is actually like
`touhou -status:deleted`, then we don't know the count and we have to calculate it on demand.

This option is being removed because it did the opposite of what people thought it did. People
thought it made deleted posts visible, when actually it made them more hidden.
This commit is contained in:
evazion
2022-04-30 20:54:29 -05:00
parent fdc1130aea
commit f117049750
10 changed files with 17 additions and 73 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
app/policies/user_policy.rb
View File

@@ -47,7 +47,7 @@ class UserPolicy < ApplicationPolicy
blacklisted_tags time_zone per_page custom_style theme
receive_email_notifications always_resize_images
new_post_navigation_layout enable_private_favorites
hide_deleted_posts style_usernames show_deleted_children
style_usernames show_deleted_children
disable_categorized_saved_searches disable_tagged_filenames
disable_mobile_gestures enable_safe_mode
enable_desktop_mode disable_post_tooltips