From fbe39148cdd336ffac70a84ecddf9f950448fbd8 Mon Sep 17 00:00:00 2001 From: evazion Date: Sun, 26 Jan 2020 13:09:35 -0600 Subject: [PATCH] users: remove opt_out_tracking account setting. This setting doesn't do anything any more. It was only ever used to disable tracking of some (but not all) data in Mixpanel, then later in Matomo. --- app/controllers/users_controller.rb | 1 - app/models/user.rb | 2 ++ app/views/users/edit.html.erb | 1 - 3 files changed, 2 insertions(+), 2 deletions(-) diff --git a/app/controllers/users_controller.rb b/app/controllers/users_controller.rb index ad0ad5053..d8f480886 100644 --- a/app/controllers/users_controller.rb +++ b/app/controllers/users_controller.rb @@ -119,7 +119,6 @@ class UsersController < ApplicationController disable_categorized_saved_searches disable_tagged_filenames disable_cropped_thumbnails disable_mobile_gestures enable_safe_mode disable_responsive_mode disable_post_tooltips - enable_recommended_posts opt_out_tracking ] permitted_params << :name if context == :create diff --git a/app/models/user.rb b/app/models/user.rb index a57819059..8a27ba711 100644 --- a/app/models/user.rb +++ b/app/models/user.rb @@ -33,6 +33,8 @@ class User < ApplicationRecord # - enable_recent_searches (enabled by 499) # - disable_cropped_thumbnails (enabled by 22) # - has_saved_searches + # - opt_out_tracking + # - enable_recommended_posts BOOLEAN_ATTRIBUTES = %w( is_banned has_mail diff --git a/app/views/users/edit.html.erb b/app/views/users/edit.html.erb index 4517b22d3..0e8402bad 100644 --- a/app/views/users/edit.html.erb +++ b/app/views/users/edit.html.erb @@ -66,7 +66,6 @@ <%= f.input :disable_post_tooltips, :as => :select, :hint => "Disable advanced tooltips when hovering over thumbnails", :collection => [["No", "false"], ["Yes", "true"]], :include_blank => false %> <%= f.input :disable_cropped_thumbnails, :as => :select, :hint => "Disable cropped (square) thumbnails on mobile", :collection => [["No", "false"], ["Yes", "true"]], :include_blank => false %> <%= f.input :disable_responsive_mode, :as => :select, :collection => [["No", "false"], ["Yes", "true"]], :include_blank => false, :hint => "Disable alternative layout for mobile and tablet" %> - <%= f.input :opt_out_tracking, :as => :select, :collection => [["No", "false"], ["Yes", "true"]], :include_blank => false, :hint => "Opt out of tracking" %> <%= f.input :favorite_tags, :label => "Frequent tags", :hint => "A list of tags that you use often. They will appear when using the list of Related Tags.", :input_html => { :rows => 5, :data => { :autocomplete => "tag-query" } } %> <%= f.input :custom_style, :label => "Custom CSS style".html_safe, :hint => "CSS rules to apply to the whole site.", :input_html => {:size => "40x5"} %>