evazion
|
40dda8a672
|
Merge pull request #5138 from nonamethanks/fix-fandom-links
Fix normalization for fandom sources
|
2022-04-22 00:36:11 -05:00 |
|
nonamethanks
|
e1b9166a56
|
Sources: do not use an empty else in case blocks
|
2022-04-22 03:53:18 +02:00 |
|
nonamethanks
|
3b055138ff
|
Fix normalization for fandom sources
|
2022-04-22 03:27:05 +02:00 |
|
evazion
|
9c5b60b630
|
sources: normalize artist urls for ask.fm, ameblo.jp, anidb.net, animenewsnetwork.com
|
2022-03-31 02:36:17 -05:00 |
|
evazion
|
b8f154d301
|
artists: add more artist url icons.
|
2022-03-30 22:04:24 -05:00 |
|
evazion
|
34aa22f90b
|
sources: fix fandom.com page urls.
Fix it so that sources like this:
* https://vignette.wikia.nocookie.net/valkyriecrusade/images/c/c5/Crimson_Hatsune_H.png/revision/latest?cb=20180702031954
link to this:
* https://valkyriecrusade.fandom.com/?file=Crimson_Hatsune_H.png
instead of this
* https://valkyriecrusade.fandom.com/wiki/File:Crimson_Hatsune_H.png
The `/wiki/File:$name` URL redirects to whatever wiki page contains the
image instead of showing the file itself.
|
2022-03-23 23:38:06 -05:00 |
|
evazion
|
fbca31d29e
|
artists: add more artist url icons.
|
2022-03-23 02:59:22 -05:00 |
|
evazion
|
3aa5cab2aa
|
sources: refactor normalize_for_source.
`normalize_for_source` was used to convert image URLs to page URLs when displaying sources
on the post show page. Move all the code for converting image URLs to page URLs from
`Sources::Strategies#normalize_for_source` to `Source::URL#page_url`.
Before we had to be very careful in source strategies not to make any network calls in
`normalize_for_source`, since it was used in the view for the post show page. Now all the
code for generating page URLs is isolated in Source::URL, which makes source strategies
simpler. It also makes it easier to check if a source is an image URL or page URL, and if
the image URL is convertible to a page URL, which will make autotagging bad_link or
bad_source feasible.
Finally, this fixes it to generate better page URLs in a handful of cases:
* https://www.artstation.com/artwork/qPVGP instead of https://anubis1982918.artstation.com/projects/qPVGP
* https://yande.re/post/show?md5=b4b1d11facd1700544554e4805d47bb6s instead of https://yande.re/post?tags=md5:b4b1d11facd1700544554e4805d47bb6
* http://gallery.minitokyo.net/view/365677 instead of http://gallery.minitokyo.net/download/365677
* https://valkyriecrusade.fandom.com/wiki/File:Crimson_Hatsune_H.png instead of https://valkyriecrusade.wikia.com/wiki/File:Crimson_Hatsune_H.png
* https://rule34.paheal.net/post/view/852405 instead of https://rule34.paheal.net/post/list/md5:854806addcd3b1246424e7cea49afe31/1
|
2022-03-23 01:34:04 -05:00 |
|
