jaculabilis/danbooru
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity
7,951 Commits 1 Branch 0 Tags
601e58d5c507e608d223d514b7e8ab095550934b
Commit Graph

2453 Commits

Author SHA1 Message Date
evazion
b50b7f2a91 tag aliases: fix bug in alias resolution. 
Bug: Searching for an aliased tag returns an empty page instead of
showing the results for the real tag.

Cause: The query parsing code runs the search string through
`.mb_chars.downcase` before calling `TagAlias.to_aliased`, so the input
to `to_aliased` is actually a ActiveSupport::Multibyte::Chars object.
This breaks the `aliases[name]` hash lookup because `name` is not a
plain string.

Fixup for c7bcce429.
 2019-08-12 18:10:49 -05:00
evazion
d8749e7dfe search: save a query in fast_count (#4120). 
During single-tag searches we look up the tag once in Post.fast_count
and later on when rendering the wiki excerpt. Doing a raw query here
meant that Rails couldn't cache the query, so it got ran again when
rendering the excerpt.
 2019-08-12 13:38:45 -05:00
evazion
a6163258bf Post.fast_count: skip alias normalization. 
Post.fast_count calls Tag.normalize_query to normalize the tag string
used for the pfc cache key. This slightly improves cache sharing at the
expense of an extra query during tag searches. The extra query isn't
worth it.
 2019-08-12 13:38:45 -05:00
evazion
30a378865e TagAlias.to_aliased: avoid query on blank arguments. 
PostQueryBuilder calls `to_aliased` with empty arguments in some cases.
Return early to avoid a query in those cases.
 2019-08-12 13:38:45 -05:00
evazion
7316f41d1d Fix #4106: Allow moderators to IP ban subnets. 2019-08-12 02:12:56 -05:00
evazion
9729eeb829 ip bans: remove unused code. 2019-08-11 23:38:03 -05:00
evazion
c7bcce429e Fix #4129: Remove tag alias caching. 2019-08-10 22:04:55 -05:00
evazion
4f024d2360 pools/show: fix N+1 query on pool show page. 
Fix a N+1 query when fetching posts to render thumbnails. Also adds
support for the `limit` url param on the posts show page.
 2019-08-09 00:05:50 -05:00
evazion
9a6add9730 newrelic: refactor error logging. 
* Factor out New Relic logging to DanbooruLogger class.
* Log all exceptions to New Relic, not just statement timeouts.
 2019-08-08 22:16:39 -05:00
evazion
5231371100 posts: drop img.ly source normalization. 
There are only two posts from this site and the site itself is defunct:

* https://danbooru.donmai.us/posts/1561685
* https://danbooru.donmai.us/posts/1412508
* https://img.ly/ofxl
 2019-08-07 22:11:07 -05:00
evazion
7f482dc35b deviantart: normalize wixmp.com sources to page urls. 
Normalize sources like this:

   https://images-wixmp-ed30a86b8c4ca887773594c2.wixmp.com/f/ab917938-d8c1-4b58-933d-0d38c390461f/ddcyi98-cbd39da2-f528-4b26-aadb-a16fe91442b2.jpg/v1/fill/w_1280,h_1760,q_100,strp/tifa_by_chubymi_ddcyi98-fullview.jpg?token=eyJ0eXAiOiJKV1QiLCJhbGciOiJIUzI1NiJ9.eyJzdWIiOiJ1cm46YXBwOjdlMGQxODg5ODIyNjQzNzNhNWYwZDQxNWVhMGQyNmUwIiwiaXNzIjoidXJuOmFwcDo3ZTBkMTg4OTgyMjY0MzczYTVmMGQ0MTVlYTBkMjZlMCIsIm9iaiI6W1t7ImhlaWdodCI6Ijw9MTc2MCIsInBhdGgiOiJcL2ZcL2FiOTE3OTM4LWQ4YzEtNGI1OC05MzNkLTBkMzhjMzkwNDYxZlwvZGRjeWk5OC1jYmQzOWRhMi1mNTI4LTRiMjYtYWFkYi1hMTZmZTkxNDQyYjIuanBnIiwid2lkdGgiOiI8PTEyODAifV1dLCJhdWQiOlsidXJuOnNlcnZpY2U6aW1hZ2Uub3BlcmF0aW9ucyJdfQ.Uochlma4QJmLwL2ZGMmvTr4HMva4m4bCeF3vnyPSw4I

to this:

   https://www.deviantart.com/chubymi/art/Tifa-807825644

on the sidebar of the posts show page.
 2019-08-06 12:04:05 -05:00
evazion
0c6d9f60bd Remove unused mailers. 2019-08-06 10:42:45 -05:00
evazion
9163b3cb1c validations: drop superfluous return statements. 
Returning true or false in a validation callback doesn't do anything, so
drop these superfluous return statements.
 2019-08-04 15:45:05 -05:00
evazion
a926b162be models: drop unnecessary presence validations. 
In rails 5, belongs_to associations automatically validate that the
associated item is present, meaning that we don't need to validate these
things manually any more.
 2019-08-04 14:40:37 -05:00
evazion
39bd766b34 Fix #4053: Add disapproval index improvements. 
Add search form to /moderator/post/disapprovals.
 2019-08-02 22:03:03 -05:00
evazion
6c69165780 Fix #4105: IP bans leak banned IPs in /mod_actions. 2019-08-01 21:21:18 -05:00
evazion
065609ff4f artists: prevent creating artist entries for non-artist tags (#4107, 2717). 
Validate that artist entries belong to an artist tag. Don't allow
creating artist entries for character/copyright/meta tags, but do allow
entries for general tags (the gentag will be automatically changed to an
artist tag).
 2019-08-01 20:20:06 -05:00
evazion
bcaefa0a7e Fix #4107: Can't create artist entry if tag already has a wiki #4107 2019-08-01 19:34:21 -05:00
Albert Yi
5e5e86c383 limit number of synchronous saved search updates 2019-07-02 17:16:33 -07:00
Albert Yi
318bee9953 make saved search populate synchronous for gold users 2019-07-02 12:30:42 -07:00
Albert Yi
21ba1000f1 fixes #4079: Allow deleted forum items to be seen with the is_deleted parameter 2019-05-17 13:11:24 -07:00
Albert Yi
04edc3f533 update factories + tests 2019-05-10 17:31:07 -07:00
Albert Yi
06045ac0d1 fix bug with only param 2019-04-18 13:28:14 -07:00
Albert Yi
0daa8184d4 handle include param for as_json and to_xml 2019-04-18 12:54:36 -07:00
Albert Yi
a12f6badde add RequestStore gem, support universal only param for api endpoints (fixes #4068) 2019-04-17 12:00:42 -07:00
Albert Yi
78322b38f4 fixes #4064: Artist new page giving false rejection messages 2019-02-25 11:03:45 -08:00
Albert Yi
d8aabff77b remove post keeper references 2019-01-31 15:45:06 -08:00
Albert Yi
caf60d690d better check for forum post votability 2019-01-28 17:23:33 -08:00
Albert Yi
a5943d2c3a Merge pull request #4044 from r888888888/tag-change-notices 
Tag change notices
 2019-01-24 14:23:35 -08:00
evazion
1292717c52 dynamic requests: handle deleted/processing/queued statuses (#3824) 
Fix bug where [ta:1234] didn't render if the request's status was
'deleted', 'queued', or 'processing'.
 2019-01-24 13:52:16 -06:00
Albert Yi
17ae357da9 eliminate mixpanel references 2019-01-23 16:37:44 -08:00
Albert Yi
1550538dc1 Tag change notices 
This adds a small notice at the bottom of post searches if a single tag search is the target of any tag change request.
 2019-01-22 17:22:07 -08:00
Albert Yi
68a5a4be09 handle error state better for recommender service 2019-01-22 14:57:31 -08:00
evazion
a284d3fb4a BURs: allow only pending BURs to be rejected. 
Fix it being possible to reject approved BURs, or to re-reject already
rejected BURs.

Rejecting an approved BUR wouldn't revert the aliases/implications, but
it would change the BUR's status to rejected.
 2019-01-15 21:20:28 -06:00
Albert Yi
f33b23d035 add post count estimates for bulk update requests 2019-01-09 15:54:55 -08:00
Albert Yi
844b1a81ba Merge pull request #4039 from evazion/fix-4038 
Fix #4038: Attempting to create an IP-ban bans the creator.
 2019-01-09 14:47:32 -08:00
Albert Yi
d97622d1bb Merge pull request #4007 from evazion/fix-4004 
Fix #4004: Add additional order by metatags for posts
 2019-01-09 14:43:15 -08:00
evazion
80f43f9a7c Fix #4038: Attempting to create an IP-ban bans the creator. 
* Rename comments.ip_addr to comments.creator_ip_addr.
* Fix belongs_to_creator to not clobber ip_addr field.
 2019-01-09 16:20:34 -06:00
Albert Yi
fa6d86e882 handle error case for recommendation service 2019-01-08 14:49:57 -08:00
Albert Yi
8b0af19f7f fixes #3824: render tag requests dynamically in the forum post 
refactoring
 2019-01-08 12:57:37 -08:00
evazion
82b09860f2 Fix #4032: /tag_aliases page is broken. 2019-01-02 15:55:24 -06:00
evazion
0ab2dfc5d2 aliases/implications: fix conflicting definitions of active scope. 2018-12-31 19:03:01 -06:00
evazion
17a5db72a6 aliases/implications: allow searching by antecedent or consequent tag type. 2018-12-31 18:55:36 -06:00
evazion
aceded710a aliases/implications: fix retired aliases being sorted first on index page. 2018-12-31 17:07:14 -06:00
evazion
d393d67a9b aliases/implications: don't destroy removed aliases (#4024). 2018-12-31 17:07:14 -06:00
evazion
f5116c5ce2 aliases/implications: allow duplicate inactive aliases/implications. 
Allow multiple pending, deleted or retired aliases/implications for the
same tag.

This is so that deleted or retired aliases can be resubmitted as new
pending requests.
 2018-12-31 17:07:14 -06:00
evazion
fde398d37b posts: clarify missing artist tag warning (#4029). 2018-12-28 15:52:49 -06:00
evazion
2170961f47 artists: improve prefilling of new artist form (#4028) 
* When creating an artist by clicking the '?' next to the artist tag in
  the tag list, prefill the new artist form by finding the artist's last
  upload and fetching its source data.

  Previously we filled the urls with the source of the artist's last
  upload, which was wrong because it was usually a direct image URL (#3078).

* Fix the other names field not escaping spaces within names to underscores.

* Fix the other names field being potentially prefilled with duplicate names.
 2018-12-27 15:03:11 -06:00
evazion
286bf2f285 artists: filter out duplicates from other names (#4028). 2018-12-27 15:03:11 -06:00
evazion
719f556dd5 aliases: warn about conflicting wikis when alias is requested. 
* Warn about conflicting wiki pages during secondary validation.

* Only warn about missing wiki if both tags are missing a wiki page.
 2018-12-26 17:30:07 -06:00