Commit Graph

11041 Commits

Author SHA1 Message Date
evazion
4939c0345a Fix test failures when removing posts from deleted pools.
These tests failed because removing posts from deleted pools is now
Builder-only.
2017-11-26 18:10:08 -06:00
evazion
a7566ae851 post_view_count_service_test.rb: fix test failure. 2017-11-26 16:17:21 -06:00
evazion
255082d3b5 tumblr: fix test failure. 2017-11-26 15:37:51 -06:00
evazion
1c5c3b5f9f Include paginator extensions in ApplicationRecord. 2017-11-26 15:34:44 -06:00
evazion
ec6d553fa6 Move execute_sql / select_value_sql etc to ApplicationRecord. 2017-11-26 13:57:52 -06:00
evazion
45cecff1a6 Move with_timeout / without_timeout to ApplicationRecord. 2017-11-26 13:57:52 -06:00
evazion
5b89f56c2e Move PostgresExtensions to ApplicationRecord. 2017-11-26 13:57:51 -06:00
evazion
8a0f600ac2 uploads: fix rating:S not being recognized by rating validator. 2017-11-26 11:54:13 -06:00
evazion
6d9708a22e posts: don't warn about missing artist tags for official_art. 2017-11-26 11:43:46 -06:00
evazion
80e115b600 favgroups: fix race condition when adding posts to favgroups.
Adding or removing a post id to a favgroup's post_ids string is
non-atomic. Lock it to prevent simultaneous updates to the same favgroup
from clobbering each other.

Same bug as #3091.
2017-11-26 11:02:39 -06:00
evazion
810b6b8b99 Fix #3039: Test failures under ruby 2.4. 2017-11-25 21:52:32 -06:00
evazion
127e4e385b Fix dmail failures when akismet isn't configured. 2017-11-25 21:46:32 -06:00
evazion
bc3e2438d9 posts: add tests for warning validations. 2017-11-25 17:03:33 -06:00
evazion
cc1f8ab9ed posts: warn when a tag cannot be removed due to implications / automatic tags. 2017-11-25 17:03:33 -06:00
evazion
94fa835733 posts: warn when post from known source is missing an artist tag. 2017-11-25 17:03:33 -06:00
evazion
4cd372296d posts: warn when post is missing copyright tags. 2017-11-25 17:03:33 -06:00
evazion
d571efd703 posts: warn when adding artist tag with no artist entry. 2017-11-25 17:03:33 -06:00
evazion
963eacd849 posts: warn when adding newly created tags. 2017-11-25 17:03:32 -06:00
evazion
07a4bdcb21 posts: display validation warnings in flash notice. 2017-11-25 17:03:32 -06:00
evazion
aeb24b6253 Fix "Similarity: %98" -> "Similarity: 98%". 2017-11-25 16:50:12 -06:00
evazion
b62b16b5a2 Fix #3398: Show "(deleted)" next to topics in forum searches. 2017-11-24 15:58:45 -06:00
r888888888
49a5b819bd eliminate ambiguities in pool search 2017-11-22 15:46:30 -08:00
r888888888
483c8ba795 fix ambiguities in artist search 2017-11-22 15:41:50 -08:00
r888888888
f904d19b60 update rubyzip gem 2017-11-22 13:28:59 -08:00
r888888888
060762defa add service for purging files from cloudflare cache 2017-11-22 13:19:30 -08:00
r888888888
3e6cb67c57 only cache notes if a post has notes 2017-11-21 14:46:17 -08:00
Albert Yi
5b3f3622f7 Merge pull request #3397 from evazion/fix-3395
Fix #3395: Bookmarklet on pixiv url with deleted post page returns failbooru, and trying to upload it returns an error
2017-11-21 14:24:53 -08:00
evazion
0b5ed163fe Fix #3395: fix pixiv API exception when uploading bad pixiv id images.
Fixes an exception when attempting to upload a Pixiv image from a
deleted work. The download strategy tries to fetch the source data in
the course of rewriting the URL, which fails if the work has been
deleted from Pixiv.

Raise a BadIDError and leave the URL as-is (don't rewrite it).
2017-11-21 14:40:39 -06:00
evazion
183a7e07e3 pixiv: fix failbooru when uploading bad pixiv id posts.
Fixes an "incompatible character encodings: UTF-8 and ASCII-8BIT"
exception when uploading a deleted Pixiv post.

Caused by the Pixiv API error message not having the encoding set to UTF-8.
2017-11-21 14:11:59 -06:00
evazion
5ba63733d3 download/pixiv_test.rb: fix broken pixiv download tests.
This post was deleted:

  http://www.pixiv.net/member_illust.php?mode=medium&illust_id=46304614

Switch to this instead:

  http://www.pixiv.net/member_illust.php?mode=medium&illust_id=46324488
2017-11-21 13:48:07 -06:00
evazion
a14c492020 Fix #3396: Pixiv novel cover IDs are parsed incorrectly. 2017-11-21 13:03:03 -06:00
Albert Yi
4d6dc895d6 Merge pull request #3362 from BrokenEagle/feat-client-input-validation
Moved input existence validations to client (#3352)
2017-11-21 10:56:14 -08:00
Albert Yi
051c17953d Merge pull request #3393 from evazion/feat-safe-mode
Fix #3392: Add safe mode account setting.
2017-11-21 10:55:57 -08:00
Albert Yi
a72f367ad7 Merge pull request #3394 from BrokenEagle/fix-deleted-pools-editable
Add additional restrictions on updating deleted pools
2017-11-21 10:48:50 -08:00
r888888888
70e592e823 round similarity score on post presenter 2017-11-21 10:25:12 -08:00
r888888888
5c5daeac72 remove unused mobile templates 2017-11-21 10:19:24 -08:00
r888888888
902f657a5d for video/ugoira, don't render preview if file doesn't exist yet 2017-11-21 10:16:03 -08:00
evazion
f8581c8113 Fix #3321: HTML tags not converted in artist commentaries. 2017-11-21 02:42:49 -06:00
BrokenEagle
956bd707a5 Add additional restrictions on updating deleted pools 2017-11-20 19:31:11 -08:00
evazion
b3a9cd6c06 Fix Post.fast_count("pool:1537") == 0 (fixup 134958d1).
Fixup for a bug in 134958d1. `Post.fast_count("pool:1537")` still
returned zero because `Tag.is_simple_tag?` incorrectly parsed
"pool:1537" as a simple tag, so Post.fast_count still looked for it in
the tags table and found the empty "pool:1537" tag.
2017-11-20 21:21:36 -06:00
evazion
df7648b581 Fix #3392: Add safe mode account setting. 2017-11-20 18:59:53 -06:00
r888888888
91147bba88 fix nil error on delayed job index 2017-11-20 16:35:14 -08:00
r888888888
ba517af1db fix functional tests 2017-11-20 16:30:07 -08:00
r888888888
502f1298a9 fix unit tests 2017-11-20 16:30:07 -08:00
Albert Yi
f11992bd91 Merge pull request #3391 from evazion/fix-3390
Fix #3390: Searching certain metatags results in an empty paginator
2017-11-20 14:23:27 -08:00
evazion
134958d137 Fix #3390: Searching certain metatags results in an empty paginator
Fixes Post#get_count_from_cache to only lookup the count in the tags
table when the search is for a single "simple" tag.

Check memcache when the search is not a simple tag:

* multi-tag searches (touhou rating:s)
* single metatag searches (rating:s, source:"foo bar")
* negated tags (-touhou)
* wildcard tags (*touhou*)
* or searches (~touhou)
2017-11-20 14:41:02 -06:00
r888888888
9d5e4f969f fix source tests 2017-11-20 12:30:29 -08:00
Albert Yi
e21f7c14db Merge pull request #3389 from evazion/fix-3387
Fix #3387: Safebooru: Two tag searches fail for members.
2017-11-20 11:39:50 -08:00
evazion
7034a96048 Purge invalid gentags from tags table (#3390).
Purges gentags with invalid names from the tags table. Addresses #3390
(Searching certain metatags results in an empty paginator) by removing
metatags from the tags table.
2017-11-20 12:47:30 -06:00
evazion
9b887c3c3a Fix #3387: Safebooru: Two tag searches fail for members.
Makes the `rating:s` and `-status:deleted` tags not count against the
tag limit.
2017-11-19 20:58:22 -06:00