Commit Graph

49 Commits

Author SHA1 Message Date
evazion
f151285038 views: standardize page titles. 2019-08-24 22:55:35 -05:00
evazion
5b27726635 views: fixup regressions in new dmail, new feedback forms.
Fixup regression in 59b277ead. Simpleform expected `to_name`,
`user_name` methods to exist on these models.
2019-08-18 13:33:05 -05:00
evazion
59b277ead1 users: drop id_to_name, name_to_id caching.
Changes:

* Drop Users.id_to_name.
* Don't cache Users.name_to_id.
* Replace calls to name_to_id with find_by_name when possible.
* Don't autodefine creator_name in belongs_to_creator.
* Don't autodefine updater_name in belongs_to_updater.
* Instead manually define creator_name / updater_name only on models that need
  to return these fields in the api.

id_to_name was cached to reduce the impact of N+1 query patterns in
certain places, especially in api responses that return creator_name /
updater_name fields. But it still meant we were doing N calls to
memcache. Using `includes` to prefetch users avoids this N+1 pattern.

name_to_id had no need be cached, it was never used in any performance-
sensitive contexts.

Avoiding caching also avoids the need to keep these caches consistent.
2019-08-18 11:24:42 -05:00
evazion
fa19047220 autocomplete: add username autocompletion sitewide. 2019-08-11 15:38:39 -05:00
evazion
98d80a0cca Fix #4116: "Couldn't find template for digesting" errors.
Specify full path to shared partial to work around bug in the template
digesting system in Rails.
2019-08-03 17:40:45 -05:00
Albert Yi
17ae357da9 eliminate mixpanel references 2019-01-23 16:37:44 -08:00
evazion
d213173d3d Fix #4002: Always include "updated by" line when creator != updater 2018-12-08 11:30:11 -06:00
Albert Yi
b999fc86ea mixpanel fixes 2018-10-22 16:54:38 -07:00
Albert Yi
4b9f3e384f include more messaging for user feedback 2018-09-05 16:32:18 -07:00
evazion
bc7ead5396 Fix #3857: Add searching mod actions by message.
Also allow searching user feedbacks and bulk update requests.
2018-08-31 19:59:51 -05:00
evazion
47e26419d3 nav menu: add html ids to secondary nav menu links (#3844). 2018-08-27 20:57:59 -05:00
Albert Yi
cd88a8df9f fixes #3620 2018-04-12 13:00:48 -07:00
BrokenEagle
5cdd8d8f67 Standardize position of page title and secondary links
- Removed path specification for secondary links where unneeded
2017-12-28 10:20:27 -08:00
BrokenEagle
31d3215dad Fix page controller and action IDs
- Also fix affected CSS and JS files
2017-12-28 10:20:12 -08:00
evazion
d2df35092b /user_feedbacks: display "Updated N minutes ago" on edited feedbacks (#3423). 2017-12-15 11:16:24 -06:00
evazion
7cb7c2fbab Remove ruby DText implementation (#3206). 2017-07-19 16:48:42 -05:00
Albert Yi
87bcc07fae enable ragel parser for remaining dtext endpoints 2017-01-10 15:12:37 -08:00
evazion
fa74c71b6d Prevent mods from editing/deleting feedbacks given to themselves. 2016-11-28 03:57:24 -06:00
Type-kun
a7d553038f Add "disable-with" to most edit forms (should fix #2264) 2016-08-30 22:54:38 +05:00
r888888888
5e1dc81ab3 fixes #1634: Allow users to edit feedback they give out 2015-08-02 18:19:44 -07:00
r888888888
fad0ab7c93 fixes #2133 2014-04-16 17:43:34 -07:00
Toks
39a6cca62a fixes #1080 2013-07-07 19:29:24 -04:00
Toks
f653ea68ca fix feedback search html 2013-06-13 22:59:40 -04:00
Toks
7b1e5f6d9a add blank category option 2013-05-11 20:59:48 -04:00
Toks
cc17c9ce55 fixes #1560 2013-05-11 20:53:11 -04:00
Toks
92d6775e33 fixes #1529 2013-05-04 10:12:24 -04:00
r888888888
d5f575159f rename references of privileged to gold 2013-04-28 00:04:52 -07:00
Toks
ea3973d2a7 fixes #1271 2013-04-27 21:39:55 -04:00
Toks
bca4c75944 fixes #1137 2013-04-12 07:50:38 -04:00
Toks
a42f43cafe fixes #1247 2013-04-09 16:02:58 -04:00
Toks
8b33cac661 replace old user links with new format 2013-04-04 23:16:28 -04:00
Toks
4f42ab8bdb adds support for user level-dependent classes
all links to users should have their class attribute set to that user's
level_class
2013-03-30 12:04:58 -04:00
albert
7f772a6312 fixes #1042 2013-03-25 23:09:23 -04:00
小太
1a03a86592 Kill trailing whitespace in erb files 2013-03-19 23:11:58 +11:00
albert
f974ba68db fixes #767 2013-03-05 19:50:01 -05:00
albert
c51a406083 remove category column from feedback listing 2013-02-23 12:58:37 -05:00
albert
17bf33672c show error messages for user feedback creation 2013-02-23 11:21:48 -05:00
albert
efaae104fb add index on post_versions.updated_at 2013-02-20 22:24:14 -05:00
albert
c5731298fb clarify post deletion/flag logic 2013-02-19 22:03:01 -05:00
albert
ad6ad8074e fixes #396 2013-02-19 14:10:13 -05:00
albert
9e6a25f844 add ubiquitous time tags 2013-01-22 15:28:12 -05:00
albert
8749c43b3e refactored search 2013-01-10 17:45:52 -05:00
albert
1515b6822f fixes #328 2012-02-24 17:18:32 -05:00
albert
1fc88ea188 fixes #239 2012-01-07 22:44:59 -05:00
albert
34ae712be0 fixed titles 2011-10-23 16:55:57 -04:00
albert
0eb665af0d refactored dtext field helper 2011-10-21 17:45:49 -04:00
albert
f630365c3b style fixes 2011-10-17 00:39:22 -04:00
albert
c8afd34d15 added ip addr search 2011-07-29 18:04:50 -04:00
albert
98403d0cb7 fix user feedback controller test 2011-07-17 18:40:24 -04:00