Commit Graph
6297 Commits
Author SHA1 Message Date
Albert Yi 80fdafad45 Merge pull request #3201 from evazion/fix-transitive-implications
Fix #3200: Disallow creation of superfluous implications
2017-07-05 11:50:51 -07:00
Albert Yi 5d40f5ad66 Merge pull request #3198 from evazion/feat-tumblr-dtextify-artcomm
Tumblr: convert artist commentaries from HTML to DText (#3184)
2017-07-05 11:31:30 -07:00
evazion aac1463fbf implications: count 'queued' implications as active.
Bug: implications that were approved but that were still in the 'queued'
state were not seen as active yet, which led to the transitivity
validation passing because it didn't include queued implications.
2017-07-05 00:22:27 -05:00
evazion 542c673221 Fix #3200: Disallow creation of superfluous implications.
Disallow transitive implications. If a -> b -> c already exists, don't
allow a -> c.

Caveat: if b -> c already exists, and we make a BUR for a -> b and a -> c,
the BUR validates even though a -> c is redundant. It only fails
when the BUR is approved.
2017-07-05 00:22:16 -05:00
evazion cda35494a4 Disable blacklists on pages without blacklist controls. (#3183) 2017-07-03 15:10:36 -05:00
evazion c3ac4f3329 Fix #3197 - Post Replacement comment: use Replacement URL instead of Final Source
Record the URL of the image that was actually downloaded as the replacement URL.
2017-07-02 21:00:26 -05:00
evazion 5a2745ee71 Fix post replacement controller test.
Broken in 27aa9fe. Delayed jobs have to be enabled when creating a
replacement, otherwise replacement will try to immediately delete the
existing files, which fails because they're still in use.
2017-07-01 13:37:32 -05:00
evazion 0390039621 Fix expunging posts from S3 (fixup 4c4ef5c / #3180). 2017-07-01 12:30:59 -05:00
evazion f8ed7d4357 tests: fix HTTP requests failing due to webmock (#3039).
Fixes failures in source tests caused by Webmock disabling non-stubbed
HTTP requests by default.

https://github.com/bblimke/webmock#real-requests-to-network-can-be-allowed-or-disabled
2017-07-01 12:22:36 -05:00
evazion 1c06ae9f81 atom feeds: fix deprecation warnings in *_path helpers.
DEPRECATION WARNING: You are calling a `*_path` helper with the
`only_path` option explicitly set to `false`. This option will stop
working on path helpers in Rails 5. Use the corresponding `*_url` helper
instead.
2017-07-01 11:45:28 -05:00
evazion 71f84b10af tumblr: convert commentary to dtext.
* Convert Tumblr commentary to DText.
* Strip extraneous whitespace in links and blockquotes.
* Add newlines after block elements to ensure they're separated from
  subsequent blocks.
2017-07-01 11:15:48 -05:00
evazion b880b07387 sources: factor out html-to-dtext code to DText.from_html. 2017-07-01 11:15:48 -05:00
r888888888 d7690d24b0 fixes #3039 2017-06-29 16:05:01 -07:00
r888888888 c4503e9971 Revert "#2234 comment out post previews"
This reverts commit 4281d1a48f.
2017-06-29 13:15:02 -07:00
r888888888 d4c89bccfc potential fix for #3189 2017-06-29 13:09:33 -07:00
r888888888 361e98edee fix for flagger_id_neg search case where nothing is matched 2017-06-29 13:03:36 -07:00
r888888888 d2c8e9ec6a add without timeout block for supervoter calculation 2017-06-27 18:06:57 -07:00
r888888888 4c4ef5cc5b fixes #3180 2017-06-27 15:12:12 -07:00
r888888888 610e2bdedd fixes #3191 2017-06-27 14:48:55 -07:00
r888888888 a9f15cd862 remove unused pixiv test script 2017-06-27 14:48:55 -07:00
Albert Yi 39f91bdae7 Merge pull request #3195 from evazion/feat-batch-upload-thumbs
#3194: Display thumbnails on batch upload page
2017-06-27 13:43:13 -07:00
Albert Yi c5e3973d6a Merge pull request #3192 from evazion/feat-replacement-remove-tags
Post replacements: streamline removing tags; fix replacement url.
2017-06-27 13:41:50 -07:00
evazion e3a4bfd28c /upload/batch: use image proxy for embedded thumbnails. 2017-06-27 13:46:59 -05:00
evazion 281ddae35d /uploads/batch: add thumbnail previews (#3194). 2017-06-27 13:31:47 -05:00
Albert Yi d33b57b57e Merge pull request #3188 from evazion/fix-artcomm-versions-view
Fix #3187: DText is not enabled on certain views
2017-06-26 16:38:08 -07:00
Albert Yi f0fe62f077 Merge pull request #3190 from evazion/feat-tumblr-support
Add Tumblr integration (#3184)
2017-06-26 16:37:14 -07:00
evazion 9c50b24306 post replacements: add "Tags" field to dialog box.
* Adds a "Tags" field to the post replacement dialog box. The given tags
  are added to the post after replacement.

* Prefills the Tags field with certain tags that usually need to be
  removed after replacement: replaceme, image_sample, jpeg_artifacts, etc.
2017-06-26 18:17:16 -05:00
evazion 8d22ab9de8 post replacements: record upload source/filename in replacement_url.
* Record "file://#{filename}" as the replacement url when the
  replacement comes from an uploaded file.

* Record the actual url downloaded by the upload process otherwise. This
  may be different from the url given by the user, since the upload
  process may rewrite the url.
2017-06-26 14:18:57 -05:00
evazion 4fd1c6ec21 /post_replacements: fix broken source links (missing href). 2017-06-26 10:26:58 -05:00
evazion 465be6bdf5 /post_replacements: fix thumbnails of deleted posts not showing. 2017-06-26 10:25:57 -05:00
evazion fbb25666b0 tumblr: add source tests. 2017-06-25 15:34:15 -05:00
evazion 030052bf14 tumblr: rewrite html pages to image url. 2017-06-25 15:34:15 -05:00
evazion 118843b26a tumblr: fetch tags, commentary, and image urls. 2017-06-25 15:34:15 -05:00
evazion d5ce6c98ef tumblr: add tumblr api client. 2017-06-25 15:34:15 -05:00
evazion c25ca4c45c {approvals,disapprovals}/create.js.erb: fix indentation. 2017-06-25 11:09:07 -05:00
evazion 791cbbf23b Fix #3186: Mod queue: hide item even if approve/reject fails. 2017-06-25 11:08:05 -05:00
evazion 5605f0fe0b Fix #3185: Dmail Show View incorrectly using class instead of ID. 2017-06-25 10:39:49 -05:00
evazion 4681812607 /artist_commentary_versions: format commentary as dtext. 2017-06-25 10:28:46 -05:00
evazion 1889864049 /artist_commentary_versions: show post thumbnails.
Show thumbnails in the /artist_commentary_versions listing. Don't show
thumbnails when viewing the version history of a single post.
2017-06-25 10:27:43 -05:00
Albert Yi 3e1b687b8d Merge pull request #3179 from evazion/fix-tumblr-samples
Fix #3178: Rewrite Tumblr image samples
2017-06-22 16:13:39 -07:00
Albert Yi fcf80251a6 Merge pull request #3181 from evazion/feat-replacements-view
Post replacements: Add view; allow replacing from uploaded file.
2017-06-22 16:12:43 -07:00
evazion 6329d089ee post replacements: add tag match field to search form. 2017-06-22 17:03:05 -05:00
evazion 8b4e598a12 post replacements: add /post_replacements view. 2017-06-22 17:03:05 -05:00
evazion 13d49467a2 post replacements: fix search[creator_name]=... param. 2017-06-22 16:53:20 -05:00
evazion 41b9a8a044 post replacements: fix post_replacements_path helper.
Bug: `post_replacements_path` returned the wrong path because the
`/posts/:post_id/replacements` route took precedence over the
`/post_replacements` route.

Fix: declare the `/post_replacements` route first so that it takes
precedence instead.
2017-06-22 16:53:20 -05:00
evazion d3e8937716 post replacements: allow replacing with an uploaded file. 2017-06-22 16:52:55 -05:00
evazion c27668d2ef post replacements: add option to fix source after replacement.
Adds a "Final Source" field to the post replacement dialog. If
specified, the post's source field will be changed to this value after
replacement.

This makes fixing the source back to the HTML page after
replacement easier.
2017-06-22 16:51:55 -05:00
evazion 55512130e1 css: set text fields in dialogs to 100% width.
* Fixes the flag reason field being too small in the flag dialog
* Fixes the source field being too small in the post replacement dialog.
2017-06-22 14:19:28 -05:00
evazion 421bbc35a2 tumblr: rewrite samples to biggest available version. 2017-06-21 22:30:53 -05:00
evazion a9b3d28215 tumblr: fix edgecastcdn.net rewrite + add test.
https://data.tumblr.com doesn't have a valid SSL cert, so we must use
http:// instead when we rewrite to it.
2017-06-21 21:10:07 -05:00