Commit Graph

15 Commits

Author SHA1 Message Date
evazion
542c673221 Fix #3200: Disallow creation of superfluous implications.
Disallow transitive implications. If a -> b -> c already exists, don't
allow a -> c.

Caveat: if b -> c already exists, and we make a BUR for a -> b and a -> c,
the BUR validates even though a -> c is redundant. It only fails
when the BUR is approved.
2017-07-05 00:22:16 -05:00
evazion
614bf44086 /bulk_update_requests: add search form. 2017-05-23 17:23:32 -05:00
r888888888
113d8824d5 fix bur test 2017-04-19 14:04:36 -07:00
r888888888
19b8d41d09 refactor forum notifications for tag changes 2017-04-12 16:43:15 -07:00
evazion
beddc34958 tests: set Delayed::Worker.delay_jobs = false globally. 2017-02-04 17:18:51 -06:00
evazion
6dd8ec909d Set approver of aliases/implications in BURs.
Previously only the BUR's approver was set when a BUR was approved. Set
the approver for each alias/implication in the BUR as well.

Additionally:

* Refactor `approve!` to take a user instead of just a user id.
* Be mass-assignment permissions aware when setting approver_id.
2016-10-26 21:52:19 -05:00
evazion
1e8a68a56b Test that approving BUR sets approver of aliases/implications. 2016-10-26 21:52:18 -05:00
r888888888
58aa5c6d66 fix tests 2016-05-28 14:08:44 -07:00
r888888888
110569708e fix tests 2016-05-26 13:17:18 -07:00
r888888888
30415d9e1e add approver field to aliases/implications 2016-05-26 13:01:44 -07:00
r888888888
e6b16e8fe5 better validation for bulk update requests 2016-01-28 17:59:45 -08:00
r888888888
6ff02c653d dmail bulk update request errors to admin 2015-04-21 18:39:42 -07:00
r888888888
ee4c19a0dd improve bulk update req ui 2015-04-21 17:22:16 -07:00
r888888888
387dece55a update forum topic when alias/implication/update request is updated 2015-02-15 12:51:02 -08:00
r888888888
87ef2b8e0f fixes #2190 2014-06-16 17:29:35 -07:00