Commit Graph

5321 Commits

Author SHA1 Message Date
Type-kun
9da5e67a65 Another partial fix for issue #2824, which also affected ip bans and feedback
Also fixed minor errors with IP bans
2017-01-09 13:57:16 +05:00
Type-kun
c44c40c759 Partial fix for issue #2824 2017-01-08 23:58:52 +05:00
evazion
2763f7e137 Fix ordering of favlists (sort by users who favorited first).
Fix bug introduced in 6e62a4c.
2017-01-08 00:57:36 +00:00
evazion
b9fa5a0816 posts: don't revalidate md5 uniqueness on every update. 2017-01-05 14:31:02 -06:00
Albert Yi
284008e078 eliminate antivoter concept 2017-01-03 17:11:00 -08:00
Albert Yi
094f30a44e Merge pull request #2819 from evazion/opt-favorited-users
Reduce SQL queries on /posts/:id
2017-01-03 16:29:20 -08:00
Albert Yi
0f7570aaaf Merge pull request #2817 from evazion/fix-mention-autocomplete
Fix @mention autocomplete for comments & forum posts.
2017-01-03 16:20:35 -08:00
Albert Yi
b9a1e115fb add additional mod actions 2017-01-03 16:02:36 -08:00
Albert Yi
4d698bf98b add modaction helper 2017-01-03 15:04:47 -08:00
Albert Yi
ad4b55c334 fixes #2815: Posts Screen Edit Mode Bug 2017-01-03 14:54:10 -08:00
Albert Yi
59d32d22b0 Merge pull request #2814 from evazion/fix-2813
Fix #2813: /posts/random.json does not redirect nicely.
2017-01-03 14:43:18 -08:00
Albert Yi
4859a803c6 show description diffs in pool version listing 2017-01-03 14:40:53 -08:00
evazion
4e8006ae3b Optimize rendering of post commenter names.
Eager load post comments' creators and updaters. Fixes an N+1 queries
problem when rendering commenter names at:

    views/comments/partials/show/_comment.html.erb:6
    views/comments/partials/show/_comment.html.erb:20

while rendering /posts/:id pages.
2017-01-03 20:14:05 +00:00
evazion
6e62a4cc33 Optimize Post#favorited_users.
Load users in one query rather than one query per user.
2017-01-03 18:21:05 +00:00
evazion
469f48a118 Fix @mention autocomplete for comments & forum posts.
Fix comment autocomplete (broken in 1257639). Also fix forum post
autocomplete (didn't work when editing forum posts).
2017-01-02 12:53:30 -06:00
Type-kun
3d2b81d1e8 Commented out references to pool_versions table 2017-01-02 11:44:06 +05:00
evazion
ef3f390bba Fix #2813: /posts/random.json does not redirect nicely. 2017-01-01 04:04:46 -06:00
Albert Yi
e67dec5581 indicate on missing searches report whether a wiki page exists 2016-12-29 16:59:08 -08:00
Albert Yi
74d02bde44 fixes #2812: StatementInvalid exception on all Profile Pages 2016-12-29 14:39:55 -08:00
evazion
c292587edb Add missing :platinum role to user/tag/dmail_filter attr_accessible lists. 2016-12-29 16:19:36 -06:00
evazion
6645847857 Simplify User#role. 2016-12-29 15:56:48 -06:00
evazion
d2e9ff363b Fix bug preventing Platinum users from commenting.
Bug:

Platinum users get this error when commenting:

    No route matches {:action=>"show", :controller=>"posts", :id=>nil}
    missing required keys: [:id]

Fix:

The issue was that `CurrentUser.role` was nil for Platinum users, which
caused `Comment.create(create_params, :as => CurrentUser.role)` to
silently ignore the create_params because the nil role wasn't in the
attr_accessible whitelist.

Despite this, things worked accidentally for other models because they
had `attr_accessible ..., :as => [:default]` in their whitelists where
the comment model didn't.
2016-12-29 15:45:23 -06:00
Albert Yi
0ea7d78584 remove usage of vcr cassettes; delete unused fixtures; fix some broken unit tests 2016-12-28 15:47:28 -08:00
Albert Yi
b2296cab70 bug fix for saved search update on tag batch changes 2016-12-28 12:40:00 -08:00
Albert Yi
92c1a561e0 Merge pull request #2806 from evazion/fix-post-appeal-is-deleted
Fix `undefined method `is_deleted?' for nil` on /post_appeals.
2016-12-28 11:10:14 -08:00
Albert Yi
1b2c2de8b2 update link to user reports 2016-12-28 10:54:59 -08:00
evazion
8d714820a4 Fix undefined method is_deleted?' for nil` on /post_appeals.
Fix this exception:

    undefined method `is_deleted?' for nil:NilClass
    app/models/post_appeal.rb:72:in `resolved?'
    app/views/post_appeals/index.html.erb:23:in `block in _app_views_post_appeals_index_html_erb__2678117644687662585_70170674603580'
    app/views/post_appeals/index.html.erb:17:in `_app_views_post_appeals_index_html_erb__2678117644687662585_70170674603580'
    app/controllers/post_appeals_controller.rb:13:in `index'

that occurs on these pages:

    http://danbooru.donmai.us/post_appeals?limit=1&page=a2928
    http://danbooru.donmai.us/post_appeals?limit=1&page=a2929
    http://danbooru.donmai.us/post_appeals?limit=1&page=a2930
    http://danbooru.donmai.us/post_appeals?limit=1&page=a2931
    http://danbooru.donmai.us/post_appeals?limit=1&page=a2934
    http://danbooru.donmai.us/post_appeals?limit=1&page=a2936
    http://danbooru.donmai.us/post_appeals?limit=1&page=a2937
    http://danbooru.donmai.us/post_appeals?limit=1&page=a2945
    http://danbooru.donmai.us/post_appeals?limit=1&page=a2949
2016-12-27 21:33:44 -06:00
Albert Yi
3ad639521f fixes #2805: Improve nico seiga support 2016-12-27 16:11:22 -08:00
Albert Yi
2fef0cdef9 Merge pull request #2804 from evazion/feat-comment-as-mod
Add option to comment as moderator (fix #2799)
2016-12-27 11:49:36 -08:00
Albert Yi
5c0836a9c8 Merge pull request #2803 from evazion/fix-comment-cleanups
Various minor comment code cleanups
2016-12-27 11:42:08 -08:00
Albert Yi
0293d1d01c Update comment.rb
allow Comment#for_creator to handle null user id case
2016-12-27 11:32:41 -08:00
Albert Yi
7e614b7673 Merge pull request #2802 from evazion/fix-pool-archives-db
Fix "'archive_development' database is not configured." exception.
2016-12-27 11:21:15 -08:00
evazion
68744bc24a Add controls for copying commentary from source or another post. 2016-12-27 06:01:23 +00:00
evazion
be379cc4a2 Return artist commentary in /sources.json?url=<url>. 2016-12-27 06:01:23 +00:00
evazion
cc215f6a41 Add more artist commentary API endpoints.
* GET /posts/1/artist_commentary.json
* GET /artist_commentaries/1.json
2016-12-27 06:01:22 +00:00
evazion
254efd9ca2 Rearrange /artist_commentaries/search form. 2016-12-27 06:01:22 +00:00
evazion
7734e53169 Add "Help" link in /artist_commentaries subnav. 2016-12-27 06:01:22 +00:00
evazion
0af7e84c78 Fix subnav quick search bar on /artist_commentaries. 2016-12-27 06:01:21 +00:00
evazion
82e93b3c12 Allow downvoting admin comments. 2016-12-26 23:52:45 -06:00
evazion
91e368f08a Highlight stickied comments; don't dim downvoted stickies.
The highlight color uses the same color as the subnav bar background
color. Make it a tad brighter so it's more visible.
2016-12-26 23:52:45 -06:00
evazion
1257639109 Add 'post as moderator' option for comments.
* Add 'post as moderator' option to comment form. This creates a so-called sticky comment.
* Downvotes have no effect on stickied comments; they're always visible, regardless of comment thresholds.
* Only mods may sticky comments.
* Mods may sticky comments by other users.
2016-12-26 23:52:45 -06:00
evazion
390524c7f5 Remove obsolete IE8 opacity hacks; remove unused transparency mixin. 2016-12-26 23:52:27 -06:00
evazion
1b05d5068a Simplify Comment.for_creator_name. 2016-12-26 23:52:27 -06:00
evazion
9347f27059 /comments.json: add id param; allow id and post_id to take lists of ids. 2016-12-26 23:52:27 -06:00
evazion
69c50290a8 Include updater_name in /comments/1.json. 2016-12-26 23:52:27 -06:00
evazion
c165b38a91 Prevent anon users from attempting to undelete/unvote comments.
The :undelete and :unvote actions weren't covered.
2016-12-26 23:52:27 -06:00
evazion
7c838f8525 Delete unused /comments/index_all route and unused _threshold.html.erb template. 2016-12-26 23:52:27 -06:00
evazion
85011c9192 Fix "'archive_development' database is not configured." exception. 2016-12-26 23:52:27 -06:00
evazion
df22bae2be Fix "'archive_development' database is not configured." exception. 2016-12-26 15:09:43 -06:00
r888888888
2584646017 add additional formatting for delayed job listing 2016-12-24 18:00:40 -08:00