evazion
3aa5cab2aa
sources: refactor normalize_for_source.
...
`normalize_for_source` was used to convert image URLs to page URLs when displaying sources
on the post show page. Move all the code for converting image URLs to page URLs from
`Sources::Strategies#normalize_for_source` to `Source::URL#page_url`.
Before we had to be very careful in source strategies not to make any network calls in
`normalize_for_source`, since it was used in the view for the post show page. Now all the
code for generating page URLs is isolated in Source::URL, which makes source strategies
simpler. It also makes it easier to check if a source is an image URL or page URL, and if
the image URL is convertible to a page URL, which will make autotagging bad_link or
bad_source feasible.
Finally, this fixes it to generate better page URLs in a handful of cases:
* https://www.artstation.com/artwork/qPVGP instead of https://anubis1982918.artstation.com/projects/qPVGP
* https://yande.re/post/show?md5=b4b1d11facd1700544554e4805d47bb6s instead of https://yande.re/post?tags=md5:b4b1d11facd1700544554e4805d47bb6
* http://gallery.minitokyo.net/view/365677 instead of http://gallery.minitokyo.net/download/365677
* https://valkyriecrusade.fandom.com/wiki/File:Crimson_Hatsune_H.png instead of https://valkyriecrusade.wikia.com/wiki/File:Crimson_Hatsune_H.png
* https://rule34.paheal.net/post/view/852405 instead of https://rule34.paheal.net/post/list/md5:854806addcd3b1246424e7cea49afe31/1
2022-03-23 01:34:04 -05:00
evazion
28971fe103
sources: factor out site_name method.
2022-03-11 23:20:53 -06:00
evazion
2f61486ac6
sources: remove image_url method from base strategy.
...
Remove the `image_url` method from source strategies. This method would
return only the first image if a source had multiple images. The
`image_urls` method should be used instead. Tests were the main place
that still used `image_url` instead of `image_urls`.
Also make post replacements return an error if replacing with a source
that contains multiple images, instead of just blindly replacing the
post with the first image in the source.
2022-03-11 01:59:21 -06:00
evazion
74fdeef10c
sources: factor out Source::URL::Mastodon.
2022-02-26 15:08:27 -06:00
evazion
a7dc05ce63
Enable frozen string literals.
...
Make all string literals immutable by default.
2021-12-14 21:33:27 -06:00
nonamethanks
a123bf0ee8
Mastodon: fix strategy not working for direct or dead links
2021-03-09 22:35:36 +01:00
evazion
64440757c1
Merge pull request #4737 from nonamethanks/fix-mastodon-page-url
...
Sources: get correct mastodon page url
2021-03-08 01:49:56 -06:00
nonamethanks
4118a3f3c9
Baraag: fix image regex
...
Fixes a bug for Baraag.net that caused the batch bookmarklet to always pick the first picture in multi-image posts.
2021-03-06 08:50:08 +01:00
nonamethanks
ba826ff6fa
Sources: get correct mastodon page url
2021-02-26 19:45:01 +01:00
nonamethanks
ffe8f8c92d
Add baraag.net support
2021-02-15 13:51:52 +01:00
nonamethanks
5366b0781e
Convert pawoo strategy to mastodon
2021-02-15 13:51:49 +01:00
