abce4d2551
Fail loudly if we forget to whitelist a param instead of silently ignoring it. misc models: convert to strong params. artist commentaries: convert to strong params. * Disallow changing or setting post_id to a nonexistent post. artists: convert to strong params. * Disallow setting `is_banned` in create/update actions. Changing it this way instead of with the ban/unban actions would leave the artist in a partially banned state. bans: convert to strong params. * Disallow changing the user_id after the ban has been created. comments: convert to strong params. favorite groups: convert to strong params. news updates: convert to strong params. post appeals: convert to strong params. post flags: convert to strong params. * Disallow users from setting the `is_deleted` / `is_resolved` flags. ip bans: convert to strong params. user feedbacks: convert to strong params. * Disallow users from setting `disable_dmail_notification` when creating feedbacks. * Disallow changing the user_id after the feedback has been created. notes: convert to strong params. wiki pages: convert to strong params. * Also fix non-Builders being able to delete wiki pages. saved searches: convert to strong params. pools: convert to strong params. * Disallow setting `post_count` or `is_deleted` in create/update actions. janitor trials: convert to strong params. post disapprovals: convert to strong params. * Factor out quick-mod bar to shared partial. * Fix quick-mod bar to use `Post#is_approvable?` to determine visibility of Approve button. dmail filters: convert to strong params. password resets: convert to strong params. user name change requests: convert to strong params. posts: convert to strong params. users: convert to strong params. * Disallow setting password_hash, last_logged_in_at, last_forum_read_at, has_mail, and dmail_filter_attributes[user_id]. * Remove initialize_default_image_size (dead code). uploads: convert to strong params. * Remove `initialize_status` because status already defaults to pending in the database. tag aliases/implications: convert to strong params. tags: convert to strong params. forum posts: convert to strong params. * Disallow changing the topic_id after creating the post. * Disallow setting is_deleted (destroy/undelete actions should be used instead). * Remove is_sticky / is_locked (nonexistent attributes). forum topics: convert to strong params. * merges https://github.com/evazion/danbooru/tree/wip-rails-5.1 * lock pg gem to 0.21 (1.0.0 is incompatible with rails 5.1.4) * switch to factorybot and change all references Co-authored-by: r888888888 <r888888888@gmail.com> Co-authored-by: evazion <noizave@gmail.com> add diffs
38 lines
1.1 KiB
Ruby
38 lines
1.1 KiB
Ruby
class PoolElementsController < ApplicationController
|
|
respond_to :html, :xml, :json, :js
|
|
before_action :member_only
|
|
|
|
def create
|
|
@pool = Pool.find_by_name(params[:pool_name]) || Pool.find_by_id(params[:pool_id])
|
|
|
|
if @pool.present? && !@pool.is_deleted?
|
|
@post = Post.find(params[:post_id])
|
|
@pool.add!(@post)
|
|
append_pool_to_session(@pool)
|
|
else
|
|
@error = "That pool does not exist"
|
|
end
|
|
end
|
|
|
|
def destroy
|
|
@pool = Pool.find(params[:pool_id])
|
|
@post = Post.find(params[:post_id])
|
|
@pool.remove!(@post)
|
|
respond_with(@pool, :location => post_path(@post))
|
|
end
|
|
|
|
def all_select
|
|
@pools = Pool.undeleted.where("is_active = true").order("name").select("id, name")
|
|
@pools.each # hack to force rails to eager load
|
|
@pools
|
|
end
|
|
|
|
private
|
|
def append_pool_to_session(pool)
|
|
recent_pool_ids = session[:recent_pool_ids].to_s.scan(/\d+/)
|
|
recent_pool_ids << pool.id.to_s
|
|
recent_pool_ids = recent_pool_ids.slice(1, 5) if recent_pool_ids.size > 5
|
|
session[:recent_pool_ids] = recent_pool_ids.uniq.join(",")
|
|
end
|
|
end
|