1653392361
Stop updating the fav_string attribute on posts. The column still exists on the table, but is no longer used or updated. Like the pool_string in7d503f08, the fav_string was used in the past to facilitate `fav:X` searches. Posts had a hidden fav_string column that contained a list of every user who favorited the post. These were treated like fake hidden tags on the post so that a search for `fav:X` was treated like a tag search. The fav_string attribute has been unused for search purposes for a while now. It was only kept because of technicalities that required departitioning the favorites table first (340e1008e) before it could be removed. Basically, removing favorites with `@favorite.destroy` was slow because Rails always deletes object by ID, but we didn't have an index on favorites.id, and we couldn't easily add one until the favorites table was departitioned. Fixes #4652. See https://github.com/danbooru/danbooru/issues/4652#issuecomment-754993802 for more discussion of issues caused by the fav_string (in short: write amplification, post table bloat, and favorite inconsistency problems).
37 lines
1.1 KiB
Ruby
37 lines
1.1 KiB
Ruby
class FavoritesController < ApplicationController
|
|
respond_to :html, :xml, :json, :js
|
|
|
|
def index
|
|
authorize Favorite
|
|
if !request.format.html?
|
|
@favorites = Favorite.visible(CurrentUser.user).paginated_search(params)
|
|
respond_with(@favorites)
|
|
elsif params[:user_id].present?
|
|
user = User.find(params[:user_id])
|
|
redirect_to posts_path(tags: "ordfav:#{user.name}", format: request.format.symbol)
|
|
elsif !CurrentUser.is_anonymous?
|
|
redirect_to posts_path(tags: "ordfav:#{CurrentUser.user.name}", format: request.format.symbol)
|
|
else
|
|
redirect_to posts_path(format: request.format.symbol)
|
|
end
|
|
end
|
|
|
|
def create
|
|
@favorite = authorize Favorite.new(post_id: params[:post_id], user: CurrentUser.user)
|
|
@favorite.save
|
|
@post = @favorite.post.reload
|
|
|
|
flash.now[:notice] = "You have favorited this post"
|
|
respond_with(@post)
|
|
end
|
|
|
|
def destroy
|
|
@favorite = authorize Favorite.find_by!(post_id: params[:id], user: CurrentUser.user)
|
|
@favorite.destroy
|
|
@post = @favorite.post.reload
|
|
|
|
flash.now[:notice] = "You have unfavorited this post"
|
|
respond_with(@post)
|
|
end
|
|
end
|