1653392361
Stop updating the fav_string attribute on posts. The column still exists on the table, but is no longer used or updated. Like the pool_string in7d503f08, the fav_string was used in the past to facilitate `fav:X` searches. Posts had a hidden fav_string column that contained a list of every user who favorited the post. These were treated like fake hidden tags on the post so that a search for `fav:X` was treated like a tag search. The fav_string attribute has been unused for search purposes for a while now. It was only kept because of technicalities that required departitioning the favorites table first (340e1008e) before it could be removed. Basically, removing favorites with `@favorite.destroy` was slow because Rails always deletes object by ID, but we didn't have an index on favorites.id, and we couldn't easily add one until the favorites table was departitioned. Fixes #4652. See https://github.com/danbooru/danbooru/issues/4652#issuecomment-754993802 for more discussion of issues caused by the fav_string (in short: write amplification, post table bloat, and favorite inconsistency problems).
37 lines
1.0 KiB
Ruby
37 lines
1.0 KiB
Ruby
class Favorite < ApplicationRecord
|
|
belongs_to :post, counter_cache: :fav_count
|
|
belongs_to :user, counter_cache: :favorite_count
|
|
|
|
validates :user_id, uniqueness: { scope: :post_id, message: "have already favorited this post" }
|
|
after_create :upvote_post_on_create
|
|
after_destroy :unvote_post_on_destroy
|
|
|
|
scope :public_favorites, -> { where(user: User.bit_prefs_match(:enable_private_favorites, false)) }
|
|
|
|
def self.visible(user)
|
|
user.is_admin? ? all : where(user: user).or(public_favorites)
|
|
end
|
|
|
|
def self.search(params)
|
|
q = search_attributes(params, :id, :post, :user)
|
|
q.apply_default_order(params)
|
|
end
|
|
|
|
def self.available_includes
|
|
[:post, :user]
|
|
end
|
|
|
|
def upvote_post_on_create
|
|
if Pundit.policy!(user, PostVote).create?
|
|
PostVote.negative.destroy_by(post: post, user: user)
|
|
|
|
# Silently ignore the error if the user has already upvoted the post.
|
|
PostVote.create(post: post, user: user, score: 1)
|
|
end
|
|
end
|
|
|
|
def unvote_post_on_destroy
|
|
PostVote.positive.destroy_by(post: post, user: user)
|
|
end
|
|
end
|