07f706e75f
Don't create a neutral feedback, create a mod action, or dmail the user after changing a user's name. The name change is already recorded in /user_name_change_requests, so creating feedbacks and mod actions is redundant. They also expose private information (when a user deletes their account, old name changes aren't supposed to be visible any more).
35 lines
1.2 KiB
Ruby
35 lines
1.2 KiB
Ruby
require 'test_helper'
|
|
|
|
class UserNameChangeRequestTest < ActiveSupport::TestCase
|
|
context "in all cases" do
|
|
setup do
|
|
@admin = FactoryBot.create(:admin_user)
|
|
@requester = FactoryBot.create(:user)
|
|
end
|
|
|
|
context "creating a new request" do
|
|
should "change the user's name" do
|
|
@change_request = create(:user_name_change_request, user_id: @requester.id, original_name: @requester.name, desired_name: "abc")
|
|
assert_equal("abc", @requester.reload.name)
|
|
end
|
|
|
|
should "not validate if the desired name already exists" do
|
|
assert_difference("UserNameChangeRequest.count", 0) do
|
|
req = UserNameChangeRequest.create(
|
|
:user_id => @requester.id,
|
|
:original_name => @requester.name,
|
|
:desired_name => @requester.name
|
|
)
|
|
assert_equal(["Desired name already exists"], req.errors.full_messages)
|
|
end
|
|
end
|
|
|
|
should "not convert the desired name to lower case" do
|
|
uncr = create(:user_name_change_request, user: @requester, original_name: "provence.", desired_name: "Provence")
|
|
|
|
assert_equal("Provence", @requester.name)
|
|
end
|
|
end
|
|
end
|
|
end
|