abce4d2551
Fail loudly if we forget to whitelist a param instead of silently ignoring it. misc models: convert to strong params. artist commentaries: convert to strong params. * Disallow changing or setting post_id to a nonexistent post. artists: convert to strong params. * Disallow setting `is_banned` in create/update actions. Changing it this way instead of with the ban/unban actions would leave the artist in a partially banned state. bans: convert to strong params. * Disallow changing the user_id after the ban has been created. comments: convert to strong params. favorite groups: convert to strong params. news updates: convert to strong params. post appeals: convert to strong params. post flags: convert to strong params. * Disallow users from setting the `is_deleted` / `is_resolved` flags. ip bans: convert to strong params. user feedbacks: convert to strong params. * Disallow users from setting `disable_dmail_notification` when creating feedbacks. * Disallow changing the user_id after the feedback has been created. notes: convert to strong params. wiki pages: convert to strong params. * Also fix non-Builders being able to delete wiki pages. saved searches: convert to strong params. pools: convert to strong params. * Disallow setting `post_count` or `is_deleted` in create/update actions. janitor trials: convert to strong params. post disapprovals: convert to strong params. * Factor out quick-mod bar to shared partial. * Fix quick-mod bar to use `Post#is_approvable?` to determine visibility of Approve button. dmail filters: convert to strong params. password resets: convert to strong params. user name change requests: convert to strong params. posts: convert to strong params. users: convert to strong params. * Disallow setting password_hash, last_logged_in_at, last_forum_read_at, has_mail, and dmail_filter_attributes[user_id]. * Remove initialize_default_image_size (dead code). uploads: convert to strong params. * Remove `initialize_status` because status already defaults to pending in the database. tag aliases/implications: convert to strong params. tags: convert to strong params. forum posts: convert to strong params. * Disallow changing the topic_id after creating the post. * Disallow setting is_deleted (destroy/undelete actions should be used instead). * Remove is_sticky / is_locked (nonexistent attributes). forum topics: convert to strong params. * merges https://github.com/evazion/danbooru/tree/wip-rails-5.1 * lock pg gem to 0.21 (1.0.0 is incompatible with rails 5.1.4) * switch to factorybot and change all references Co-authored-by: r888888888 <r888888888@gmail.com> Co-authored-by: evazion <noizave@gmail.com> add diffs
88 lines
2.6 KiB
Ruby
88 lines
2.6 KiB
Ruby
require 'test_helper'
|
|
|
|
class PostVersionTest < ActiveSupport::TestCase
|
|
context "A post" do
|
|
setup do
|
|
Timecop.travel(1.month.ago) do
|
|
@user = FactoryBot.create(:user)
|
|
end
|
|
CurrentUser.user = @user
|
|
CurrentUser.ip_addr = "127.0.0.1"
|
|
end
|
|
|
|
teardown do
|
|
CurrentUser.user = nil
|
|
CurrentUser.ip_addr = nil
|
|
end
|
|
|
|
context "that has multiple versions: " do
|
|
setup do
|
|
PostArchive.sqs_service.stubs(:merge?).returns(false)
|
|
@post = FactoryBot.create(:post, :tag_string => "1")
|
|
@post.update_attributes(:tag_string => "1 2")
|
|
@post.update_attributes(:tag_string => "2 3")
|
|
end
|
|
|
|
context "a version record" do
|
|
setup do
|
|
@version = PostArchive.last
|
|
end
|
|
|
|
should "know its previous version" do
|
|
assert_not_nil(@version.previous)
|
|
assert_equal("1 2", @version.previous.tags)
|
|
end
|
|
end
|
|
end
|
|
|
|
context "that has been created" do
|
|
setup do
|
|
@parent = FactoryBot.create(:post)
|
|
@post = FactoryBot.create(:post, :tag_string => "aaa bbb ccc", :rating => "e", :parent => @parent, :source => "xyz")
|
|
end
|
|
|
|
should "also create a version" do
|
|
assert_equal(1, @post.versions.size)
|
|
@version = @post.versions.last
|
|
assert_equal("aaa bbb ccc", @version.tags)
|
|
assert_equal(@post.rating, @version.rating)
|
|
assert_equal(@post.parent_id, @version.parent_id)
|
|
assert_equal(@post.source, @version.source)
|
|
end
|
|
end
|
|
|
|
context "that should be merged" do
|
|
setup do
|
|
@parent = FactoryBot.create(:post)
|
|
@post = FactoryBot.create(:post, :tag_string => "aaa bbb ccc", :rating => "q", :source => "xyz")
|
|
end
|
|
|
|
should "delete the previous version" do
|
|
assert_equal(1, @post.versions.count)
|
|
@post.update_attributes(:tag_string => "bbb ccc xxx", :source => "")
|
|
@post.reload
|
|
assert_equal(1, @post.versions.count)
|
|
end
|
|
end
|
|
|
|
context "that has been updated" do
|
|
setup do
|
|
PostArchive.sqs_service.stubs(:merge?).returns(false)
|
|
Timecop.travel(1.minute.ago) do
|
|
@post = FactoryBot.create(:post, :tag_string => "aaa bbb ccc", :rating => "q", :source => "xyz")
|
|
end
|
|
@post.update_attributes(:tag_string => "bbb ccc xxx", :source => "")
|
|
end
|
|
|
|
should "also create a version" do
|
|
assert_equal(2, @post.versions.size)
|
|
@version = @post.versions.last
|
|
assert_equal("bbb ccc xxx", @version.tags)
|
|
assert_equal("q", @version.rating)
|
|
assert_equal("", @version.source)
|
|
assert_nil(@version.parent_id)
|
|
end
|
|
end
|
|
end
|
|
end
|