abce4d2551
Fail loudly if we forget to whitelist a param instead of silently ignoring it. misc models: convert to strong params. artist commentaries: convert to strong params. * Disallow changing or setting post_id to a nonexistent post. artists: convert to strong params. * Disallow setting `is_banned` in create/update actions. Changing it this way instead of with the ban/unban actions would leave the artist in a partially banned state. bans: convert to strong params. * Disallow changing the user_id after the ban has been created. comments: convert to strong params. favorite groups: convert to strong params. news updates: convert to strong params. post appeals: convert to strong params. post flags: convert to strong params. * Disallow users from setting the `is_deleted` / `is_resolved` flags. ip bans: convert to strong params. user feedbacks: convert to strong params. * Disallow users from setting `disable_dmail_notification` when creating feedbacks. * Disallow changing the user_id after the feedback has been created. notes: convert to strong params. wiki pages: convert to strong params. * Also fix non-Builders being able to delete wiki pages. saved searches: convert to strong params. pools: convert to strong params. * Disallow setting `post_count` or `is_deleted` in create/update actions. janitor trials: convert to strong params. post disapprovals: convert to strong params. * Factor out quick-mod bar to shared partial. * Fix quick-mod bar to use `Post#is_approvable?` to determine visibility of Approve button. dmail filters: convert to strong params. password resets: convert to strong params. user name change requests: convert to strong params. posts: convert to strong params. users: convert to strong params. * Disallow setting password_hash, last_logged_in_at, last_forum_read_at, has_mail, and dmail_filter_attributes[user_id]. * Remove initialize_default_image_size (dead code). uploads: convert to strong params. * Remove `initialize_status` because status already defaults to pending in the database. tag aliases/implications: convert to strong params. tags: convert to strong params. forum posts: convert to strong params. * Disallow changing the topic_id after creating the post. * Disallow setting is_deleted (destroy/undelete actions should be used instead). * Remove is_sticky / is_locked (nonexistent attributes). forum topics: convert to strong params. * merges https://github.com/evazion/danbooru/tree/wip-rails-5.1 * lock pg gem to 0.21 (1.0.0 is incompatible with rails 5.1.4) * switch to factorybot and change all references Co-authored-by: r888888888 <r888888888@gmail.com> Co-authored-by: evazion <noizave@gmail.com> add diffs
104 lines
2.9 KiB
Ruby
104 lines
2.9 KiB
Ruby
require 'test_helper'
|
|
|
|
class UserNameChangeRequestTest < ActiveSupport::TestCase
|
|
context "in all cases" do
|
|
setup do
|
|
@admin = FactoryBot.create(:admin_user)
|
|
@requester = FactoryBot.create(:user)
|
|
CurrentUser.user = @requester
|
|
CurrentUser.ip_addr = "127.0.0.1"
|
|
end
|
|
|
|
teardown do
|
|
CurrentUser.user = nil
|
|
CurrentUser.ip_addr = nil
|
|
end
|
|
|
|
context "approving a request" do
|
|
setup do
|
|
@change_request = UserNameChangeRequest.create(
|
|
:user_id => @requester.id,
|
|
:original_name => @requester.name,
|
|
:status => "pending",
|
|
:desired_name => "abc"
|
|
)
|
|
CurrentUser.user = @admin
|
|
end
|
|
|
|
should "create a dmail" do
|
|
assert_difference("Dmail.count", 2) do
|
|
@change_request.approve!
|
|
end
|
|
end
|
|
|
|
should "change the user's name" do
|
|
@change_request.approve!
|
|
@requester.reload
|
|
assert_equal("abc", @requester.name)
|
|
end
|
|
|
|
should "clear the user name cache" do
|
|
@change_request.approve!
|
|
assert_equal("abc", Cache.get("uin:#{@requester.id}"))
|
|
end
|
|
|
|
should "create feedback" do
|
|
assert_difference("UserFeedback.count", 1) do
|
|
@change_request.approve!
|
|
end
|
|
end
|
|
|
|
should "create mod action" do
|
|
assert_difference("ModAction.count", 1) do
|
|
@change_request.approve!
|
|
end
|
|
end
|
|
end
|
|
|
|
context "rejecting a request" do
|
|
setup do
|
|
@change_request = UserNameChangeRequest.create(
|
|
:user_id => @requester.id,
|
|
:original_name => @requester.name,
|
|
:status => "pending",
|
|
:desired_name => "abc"
|
|
)
|
|
CurrentUser.user = @admin
|
|
end
|
|
|
|
should "create a dmail" do
|
|
assert_difference("Dmail.count", 1) do
|
|
@change_request.reject!("msg")
|
|
end
|
|
end
|
|
|
|
should "preserve the username" do
|
|
@change_request.reject!("msg")
|
|
@requester.reload
|
|
assert_not_equal("abc", @requester.name)
|
|
end
|
|
end
|
|
|
|
context "creating a new request" do
|
|
should "not validate if the desired name already exists" do
|
|
assert_difference("UserNameChangeRequest.count", 0) do
|
|
req = UserNameChangeRequest.create(
|
|
:user_id => @requester.id,
|
|
:original_name => @requester.name,
|
|
:status => "pending",
|
|
:desired_name => @requester.name
|
|
)
|
|
assert_equal(["Desired name already exists"], req.errors.full_messages)
|
|
end
|
|
end
|
|
|
|
should "not convert the desired name to lower case" do
|
|
uncr = FactoryBot.create(:user_name_change_request, user: @requester, original_name: "provence.", desired_name: "Provence")
|
|
CurrentUser.scoped(@admin) { uncr.approve! }
|
|
|
|
assert_equal("Provence", @requester.name)
|
|
end
|
|
end
|
|
end
|
|
end
|