54a45a3021
Track the history of the tag `category` and `is_deprecated` fields in the `tag_versions` table. Adds generic Versionable and VersionFor concerns that encapsulate most of the history tracking logic. These concerns are designed to make it easy to add history to any model. There are a couple notable differences between tag versions and other versions: * There is no 1 hour edit merge window. All changes to the `category` and `is_deprecated` fields produce a new version in the tag history. * New versions aren't created when a tag is created. Versions are only created when a tag is edited for the first time. The tag's initial version isn't created until *after* the tag is edited for the first time. For example, if you change the category of a tag that was last updated 10 years ago, that will create an initial version of the tag backdated to 10 years ago, plus a new version for your edit. This is for a few reasons: * So that we don't have to create new tag versions every time a new tag is created. This would be wasteful because most tags never have their category or deprecation status change. * So that if you make a typo tag, your name isn't recorded in the tag's history forever. * So that we can create new tags in various places without having to know who created the tag (which may be unknown if the current user isn't set). * Because we don't know the full history of most tags, so we have to deal with incomplete histories anyway. This has a few important consequences: * Most tags won't have any tag versions. They only gain tag versions if they're edited. * You can't track /tag_versions to see newly created tags. It only shows changes to already existing tags. * Tag version IDs won't be in strict chronological order. Higher IDs may have created_at timestamps before lower IDs. For example, if you change the category of a tag that is 10 years old, that will create an initial version with a high ID, but with a created_at timestamp dated to 10 years ago. Fixes #4402: Track tag category changes
156 lines
4.2 KiB
Ruby
156 lines
4.2 KiB
Ruby
require 'test_helper'
|
|
|
|
module PostSets
|
|
class PostTest < ActiveSupport::TestCase
|
|
context "In all cases" do
|
|
setup do
|
|
@user = FactoryBot.create(:user)
|
|
CurrentUser.user = @user
|
|
CurrentUser.ip_addr = "127.0.0.1"
|
|
|
|
@post_1 = FactoryBot.create(:post, :tag_string => "a")
|
|
@post_2 = FactoryBot.create(:post, :tag_string => "b")
|
|
@post_3 = FactoryBot.create(:post, :tag_string => "c")
|
|
end
|
|
|
|
teardown do
|
|
CurrentUser.user = nil
|
|
CurrentUser.ip_addr = nil
|
|
end
|
|
|
|
context "a set for page 2" do
|
|
should "return the second element" do
|
|
@set = PostSets::Post.new("", 2, 1)
|
|
assert_equal(@post_2.id, @set.posts.first.id)
|
|
end
|
|
end
|
|
|
|
context "a set for the 'a' tag query" do
|
|
setup do
|
|
@post_4 = FactoryBot.create(:post, :tag_string => "a")
|
|
@post_5 = FactoryBot.create(:post, :tag_string => "a")
|
|
end
|
|
|
|
context "with no page" do
|
|
setup do
|
|
@set = PostSets::Post.new("a")
|
|
::Post.stubs(:records_per_page).returns(1)
|
|
end
|
|
|
|
should "return the first element" do
|
|
assert_equal(@post_5.id, @set.posts.first.id)
|
|
end
|
|
end
|
|
|
|
context "for before the first element" do
|
|
setup do
|
|
@set = PostSets::Post.new("a", "b#{@post_5.id}")
|
|
::Post.stubs(:records_per_page).returns(1)
|
|
end
|
|
|
|
should "return the second element" do
|
|
assert_equal(@post_4.id, @set.posts.first.id)
|
|
end
|
|
end
|
|
|
|
context "for after the second element" do
|
|
setup do
|
|
@set = PostSets::Post.new("a", "a#{@post_4.id}")
|
|
@set.stubs(:records_per_page).returns(1)
|
|
end
|
|
|
|
should "return the first element" do
|
|
assert_equal(@post_5.id, @set.posts.first.id)
|
|
end
|
|
end
|
|
end
|
|
|
|
context "a set going to the 1,001st page" do
|
|
setup do
|
|
@set = PostSets::Post.new("a", 1_001)
|
|
end
|
|
|
|
should "fail" do
|
|
assert_raises(PaginationExtension::PaginationError) do
|
|
@set.posts
|
|
end
|
|
end
|
|
end
|
|
|
|
context "a set for the 'a b c' tag query" do
|
|
context "for a non-gold user" do
|
|
should "fail" do
|
|
@set = PostSets::Post.new("a b c", user: create(:user))
|
|
|
|
assert_raises(PostQuery::TagLimitError) do
|
|
@set.posts
|
|
end
|
|
end
|
|
end
|
|
|
|
context "for a gold user" do
|
|
should "pass" do
|
|
@set = PostSets::Post.new("a b c", user: create(:gold_user))
|
|
|
|
assert_nothing_raised do
|
|
@set.posts
|
|
end
|
|
end
|
|
end
|
|
end
|
|
|
|
context "a set for the 'a' tag query" do
|
|
setup do
|
|
@set = PostSets::Post.new("a")
|
|
end
|
|
|
|
should "normalize its tag query" do
|
|
assert_equal("a", @set.tag_string)
|
|
end
|
|
|
|
should "know the count" do
|
|
assert_equal(1, @set.posts.total_count)
|
|
end
|
|
|
|
should "find the posts" do
|
|
assert_equal(@post_1.id, @set.posts.first.id)
|
|
end
|
|
|
|
context "that has a matching wiki page" do
|
|
setup do
|
|
@wiki_page = FactoryBot.create(:wiki_page, :title => "a")
|
|
end
|
|
|
|
should "find the wiki page" do
|
|
assert_not_nil(@set.wiki_page)
|
|
assert_equal(@wiki_page.id, @set.wiki_page.id)
|
|
end
|
|
end
|
|
|
|
context "that has a matching artist" do
|
|
should "find the artist" do
|
|
set = PostSets::Post.new("bkub")
|
|
artist = create(:artist, name: "bkub")
|
|
|
|
assert_not_nil(set.artist)
|
|
assert_equal(artist, set.artist)
|
|
end
|
|
end
|
|
end
|
|
|
|
context "#per_page method" do
|
|
should "take the limit from the params first, then the limit:<n> metatag, then the account settings" do
|
|
set = PostSets::Post.new("a limit:23 b", 1, 42)
|
|
assert_equal(42, set.per_page)
|
|
|
|
set = PostSets::Post.new("a limit:23 b", 1, nil)
|
|
assert_equal(23, set.per_page)
|
|
|
|
set = PostSets::Post.new("a", 1, nil)
|
|
assert_equal(CurrentUser.user.per_page, set.per_page)
|
|
end
|
|
end
|
|
end
|
|
end
|
|
end
|