Fail loudly if we forget to whitelist a param instead of silently ignoring it. misc models: convert to strong params. artist commentaries: convert to strong params. * Disallow changing or setting post_id to a nonexistent post. artists: convert to strong params. * Disallow setting `is_banned` in create/update actions. Changing it this way instead of with the ban/unban actions would leave the artist in a partially banned state. bans: convert to strong params. * Disallow changing the user_id after the ban has been created. comments: convert to strong params. favorite groups: convert to strong params. news updates: convert to strong params. post appeals: convert to strong params. post flags: convert to strong params. * Disallow users from setting the `is_deleted` / `is_resolved` flags. ip bans: convert to strong params. user feedbacks: convert to strong params. * Disallow users from setting `disable_dmail_notification` when creating feedbacks. * Disallow changing the user_id after the feedback has been created. notes: convert to strong params. wiki pages: convert to strong params. * Also fix non-Builders being able to delete wiki pages. saved searches: convert to strong params. pools: convert to strong params. * Disallow setting `post_count` or `is_deleted` in create/update actions. janitor trials: convert to strong params. post disapprovals: convert to strong params. * Factor out quick-mod bar to shared partial. * Fix quick-mod bar to use `Post#is_approvable?` to determine visibility of Approve button. dmail filters: convert to strong params. password resets: convert to strong params. user name change requests: convert to strong params. posts: convert to strong params. users: convert to strong params. * Disallow setting password_hash, last_logged_in_at, last_forum_read_at, has_mail, and dmail_filter_attributes[user_id]. * Remove initialize_default_image_size (dead code). uploads: convert to strong params. * Remove `initialize_status` because status already defaults to pending in the database. tag aliases/implications: convert to strong params. tags: convert to strong params. forum posts: convert to strong params. * Disallow changing the topic_id after creating the post. * Disallow setting is_deleted (destroy/undelete actions should be used instead). * Remove is_sticky / is_locked (nonexistent attributes). forum topics: convert to strong params. * merges https://github.com/evazion/danbooru/tree/wip-rails-5.1 * lock pg gem to 0.21 (1.0.0 is incompatible with rails 5.1.4) * switch to factorybot and change all references Co-authored-by: r888888888 <r888888888@gmail.com> Co-authored-by: evazion <noizave@gmail.com> add diffs
116 lines
3.7 KiB
Ruby
116 lines
3.7 KiB
Ruby
require 'test_helper'
|
|
|
|
class WikiPageTest < ActiveSupport::TestCase
|
|
setup do
|
|
CurrentUser.ip_addr = "127.0.0.1"
|
|
end
|
|
|
|
teardown do
|
|
CurrentUser.user = nil
|
|
CurrentUser.ip_addr = nil
|
|
end
|
|
|
|
context "A wiki page" do
|
|
context "that is locked" do
|
|
should "not be editable by a member" do
|
|
CurrentUser.user = FactoryBot.create(:moderator_user)
|
|
@wiki_page = FactoryBot.create(:wiki_page, :is_locked => true)
|
|
CurrentUser.user = FactoryBot.create(:user)
|
|
@wiki_page.update_attributes(:body => "hello")
|
|
assert_equal(["Is locked and cannot be updated"], @wiki_page.errors.full_messages)
|
|
end
|
|
|
|
should "be editable by a moderator" do
|
|
CurrentUser.user = FactoryBot.create(:moderator_user)
|
|
@wiki_page = FactoryBot.create(:wiki_page, :is_locked => true)
|
|
CurrentUser.user = FactoryBot.create(:moderator_user)
|
|
@wiki_page.update_attributes(:body => "hello")
|
|
assert_equal([], @wiki_page.errors.full_messages)
|
|
end
|
|
end
|
|
|
|
context "updated by a moderator" do
|
|
setup do
|
|
@user = FactoryBot.create(:moderator_user)
|
|
CurrentUser.user = @user
|
|
@wiki_page = FactoryBot.create(:wiki_page)
|
|
end
|
|
|
|
should "allow the is_locked attribute to be updated" do
|
|
@wiki_page.update_attributes(:is_locked => true)
|
|
@wiki_page.reload
|
|
assert_equal(true, @wiki_page.is_locked?)
|
|
end
|
|
end
|
|
|
|
context "updated by a regular user" do
|
|
setup do
|
|
@user = FactoryBot.create(:user)
|
|
CurrentUser.user = @user
|
|
@wiki_page = FactoryBot.create(:wiki_page, :title => "HOT POTATO", :other_names => "foo*bar baz")
|
|
end
|
|
|
|
should "not allow the is_locked attribute to be updated" do
|
|
@wiki_page.update_attributes(:is_locked => true)
|
|
assert_equal(["Is locked and cannot be updated"], @wiki_page.errors.full_messages)
|
|
@wiki_page.reload
|
|
assert_equal(false, @wiki_page.is_locked?)
|
|
end
|
|
|
|
should "normalize its title" do
|
|
assert_equal("hot_potato", @wiki_page.title)
|
|
end
|
|
|
|
should "normalize its other names" do
|
|
@wiki_page.update(:other_names => "foo*bar baz baz 加賀(艦これ)")
|
|
assert(%w[foo*bar baz 加賀(艦これ)], @wiki_page.other_names_array)
|
|
end
|
|
|
|
should "search by title" do
|
|
matches = WikiPage.titled("hot potato")
|
|
assert_equal(1, matches.count)
|
|
assert_equal("hot_potato", matches.first.title)
|
|
end
|
|
|
|
should "search other names with wildcards" do
|
|
matches = WikiPage.search(other_names_match: "fo*")
|
|
assert_equal([@wiki_page.id], matches.map(&:id))
|
|
end
|
|
|
|
should "create versions" do
|
|
assert_difference("WikiPageVersion.count") do
|
|
@wiki_page = FactoryBot.create(:wiki_page, :title => "xxx")
|
|
end
|
|
|
|
assert_difference("WikiPageVersion.count") do
|
|
@wiki_page.title = "yyy"
|
|
Timecop.travel(1.day.from_now) do
|
|
@wiki_page.save
|
|
end
|
|
end
|
|
end
|
|
|
|
should "revert to a prior version" do
|
|
@wiki_page.title = "yyy"
|
|
Timecop.travel(1.day.from_now) do
|
|
@wiki_page.save
|
|
end
|
|
version = WikiPageVersion.first
|
|
@wiki_page.revert_to!(version)
|
|
@wiki_page.reload
|
|
assert_equal("hot_potato", @wiki_page.title)
|
|
end
|
|
|
|
should "differentiate between updater and creator" do
|
|
another_user = FactoryBot.create(:user)
|
|
CurrentUser.scoped(another_user, "127.0.0.1") do
|
|
@wiki_page.title = "yyy"
|
|
@wiki_page.save
|
|
end
|
|
version = WikiPageVersion.last
|
|
assert_not_equal(@wiki_page.creator_id, version.updater_id)
|
|
end
|
|
end
|
|
end
|
|
end
|